Drop support for NC 28+29, requires PHP >= 8.1, update deps, add rector #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
blizzz
commented
May 2, 2025
blizzz
commented
- NC 28 and 29 are EOL (stable-6 is branched off)
- Hence we can bump the PHP requirements
- And so also bump dependencies
- Sugar on top is the rector configuration
blizzz
force-pushed
the
build/drop-28+39
branch
3 times, most recently
from
dfb1859 to
d83d1a7
Compare
- bumps version to 7.0.0 - upates dependencies Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
fixes flakyness through rate limitation Signed-off-by: Arthur Schiwon <[email protected]>
mejo-
approved these changes
May 13, 2025
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Nice to see all the code cleanup changes from rector 🚀
elzody
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.