wip #978
Closed
wip #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <[email protected]>
blizzz
requested changes
Aug 13, 2025
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
The changes are not resulting in reliable behaviour in this form (plus code style).
| $usersFound=$this->ensureUser($rawUidCandidate); | ||
| if(count($usersFound) != 1) | ||
| { | ||
| throw new NoUserFoundException('User' . $rawUidCandidate . ' not valid or not found'); |
Member
There was a problem hiding this comment.
This will work on maybe 99% of the cases, but not where the search attributes are configured in a way that would not reliably find the user.
Should not throw but continue with previous behaviour.
| { | ||
| throw new NoUserFoundException('User' . $rawUidCandidate . ' not valid or not found'); | ||
| } | ||
| $user = array_keys($usersFound)[0]; |
Member
There was a problem hiding this comment.
There is a risk that more records are returned and that the first one is not the correct one.
It would be acceptable to cycle through the result and compare with the uid candidate (after sanitizing), for instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.