Skip to content

fix: remove unsupported function #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
solracsf wants to merge 2 commits into from
Closed

fix: remove unsupported function #980

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc70636
fix: remove unsupported function
solracsf Aug 15, 2025
8c3f6d7
fix: lint
solracsf Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions lib/GroupManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

use OCA\User_SAML\Exceptions\GroupNotFoundException;
use OCA\User_SAML\Exceptions\NonMigratableGroupException;
use OCA\User_SAML\Jobs\MigrateGroups;
use OCP\BackgroundJob\IJobList;
use OCP\EventDispatcher\IEventDispatcher;
use OCP\Group\Events\BeforeGroupCreatedEvent;
Expand Down Expand Up @@ -90,8 +89,6 @@ public function handleIncomingGroups(IUser $user, array $samlGroupNames): void {
}

$this->updateUserGroups($user, $samlGroupNames);
// TODO: drop following line with dropping NC 28 support
$this->evaluateGroupMigrations($samlGroupNames);
}

protected function updateUserGroups(IUser $user, array $samlGroupNames): void {
Expand Down Expand Up @@ -223,15 +220,6 @@ protected function hasSamlBackend(IGroup $group): bool {
return in_array('user_saml', $group->getBackendNames());
}

protected function evaluateGroupMigrations(array $groups): void {
$candidateInfo = $this->getCandidateInfoIfValid();
if ($candidateInfo === null) {
return;
}

$this->jobList->add(MigrateGroups::class, ['gids' => $groups]);
}

protected function isGroupInTransitionList(string $groupId): bool {
$candidateInfo = $this->getCandidateInfoIfValid();
if (!$candidateInfo) {
Expand Down
Loading