-
Notifications
You must be signed in to change notification settings - Fork 25
fix: toolbar buttons disappear on window resize #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
48e6fc4 to
fd18bc9
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: Benjamin Frueh <[email protected]>
Signed-off-by: Benjamin Frueh <[email protected]>
b117fe6 to
ca86fbc
Compare
|
Rebased and resolved the conflicts |
Problem
Custom toolbar buttons disappear on toolbar re-render (e.g. when Excalidraw changes to mobile).
The hooks used reference guards to prevent duplicate button insertion. When Excalidraw rebuilt the toolbar these still held stale references to removed buttons, blocking re-insertion. Additionally, each hook implemented its own rendering logic.
Solution
ToolbarButtoncomponent to handle the custom toolbar button renderingMutationObserverto watch for Excalidraw class changes and re-render buttons automaticallyuseEmojiPicker,useSmartPicker,useTableInsertion,useAssistant,useComment) to use the centralized component