Merged
Conversation
Unfortunately the zip library keeps breaking semver in minor versions -- see for example #3074. Switch to the eazip library which seems to both be more straightforward and be easier to use.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3093 +/- ##
==========================================
+ Coverage 84.26% 84.29% +0.02%
==========================================
Files 156 156
Lines 42536 42551 +15
==========================================
+ Hits 35843 35868 +25
+ Misses 6693 6683 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates nextest’s record/portable recording implementation to use the eazip crate instead of zip, aiming to avoid repeated semver breakages in the previous zip dependency.
Changes:
- Replace
zipreader/writer usage witheazipacross record writing, reading, and portable recording support. - Introduce shared
FileOptionshelpers for stored vs zstd-compressed entries. - Update internal tooling and integration tests to use
eazipand adjust error handling accordingly.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| nextest-runner/src/record/recorder.rs | Switch store.zip writing from ZipWriter to eazip::ArchiveWriter, using stored/zstd options helpers. |
| nextest-runner/src/record/reader.rs | Switch store.zip reading from ZipArchive to eazip::Archive, update file lookup and read/decompress paths. |
| nextest-runner/src/record/portable.rs | Migrate portable archive read/write logic to eazip, including inner store handling and updated tests. |
| nextest-runner/src/record/format.rs | Add stored_file_options and zstd_file_options helpers based on eazip::write::FileOptions. |
| nextest-runner/src/errors.rs | Update error types away from zip::ZipError, add archive-parse error and new portable error for compressed inner archives. |
| nextest-runner/Cargo.toml | Replace zip dependency with eazip. |
| internal-tools/zstd-dict/src/main.rs | Port dictionary training/recompression tooling from zip to eazip. |
| internal-tools/zstd-dict/Cargo.toml | Replace zip dependency with eazip. |
| integration-tests/tests/integration/record_replay.rs | Update integration tests to read/write archives via eazip. |
| integration-tests/Cargo.toml | Replace zip dev-dependency with eazip. |
| cargo-nextest/src/dispatch/utility/debug.rs | Adjust matching logic now that ZipError is no longer re-exported. |
| Cargo.toml | Add workspace dependency on eazip, remove zip. |
| Cargo.lock | Lockfile updates for eazip addition and zip removal. |
Comments suppressed due to low confidence (1)
nextest-runner/src/errors.rs:30
nextest-runneris published on crates.io (has docs.rs link), and this PR removes the publicerrors::ZipErrorre-export. That’s a breaking API change for any downstream code matching onZipError(even if internal workspace crates have been updated). Consider keeping a deprecated compatibility re-export/type alias (or adding a dedicated error kind for archive read failures) and documenting the migration path in release notes/changelog.
use bytesize::ByteSize;
use camino::{FromPathBufError, Utf8Path, Utf8PathBuf};
use config::ConfigError;
use eazip::CompressionMethod;
use etcetera::HomeDirError;
use itertools::{Either, Itertools};
use nextest_filtering::errors::FiltersetParseErrors;
use nextest_metadata::RustBinaryId;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately the zip library keeps breaking semver in minor versions -- see for example #3074.
Switch to the eazip library which seems to both be more straightforward and be easier to use.