[nextest-runner] improve leaked-handles text strings#3199
Open
sunshowers wants to merge 1 commit intomainfrom
Open
[nextest-runner] improve leaked-handles text strings#3199sunshowers wants to merge 1 commit intomainfrom
sunshowers wants to merge 1 commit intomainfrom
Conversation
We had a bunch of different ways to represent "and leaked handles". Replace all of them with "(leaked handles)", which is equal or better in all cases. Also fix a TODO around this and switch InfoResponse over to using the platform-independent description types.
sunshowers
force-pushed
the
leaked-handles
branch
from
b1c1699 to
42539c6
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3199 +/- ##
=======================================
Coverage 85.36% 85.36%
=======================================
Files 159 159
Lines 47018 47063 +45
=======================================
+ Hits 40135 40177 +42
- Misses 6883 6886 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a bunch of different ways to represent "and leaked handles". Replace all of them with "(leaked handles)", which is equal or better in all cases. Also fix a TODO around this and switch InfoResponse over to using the platform-independent description types.