You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new collection functions like zip (can be added to Nextflow standard library)
pattern matching for instanceof (can be added to Nextflow language)
use _ for placeholder variables (can be added to Nextflow language)
Changes:
Had to remove generic type arguments from instanceof checks as the Groovy parser doesn't allow it anymore
Had to add @Slf4j to some inner classes to make log work in that class. not sure if this is a bug or just a breaking change
Current issues:
Groovy complained about a few implementers of CacheFunnel, even though I didn't see anything wrong. Converting CacheFunnel to Java fixed the issue for one but not the other
Multiple issues with the type checker that I'm pretty sure are just Groovy bugs, particularly CmdLog and DumpOp
The type checker does not recognize target in TaskConfig as a Map, seems like a bug. I wonder if it's an edge case since target is defined in super class as private and a Delegate
Overall it looks like Groovy 5 beta still has a few compiler bugs to sort out. But I'm excited to get it working so that I can bring the new pattern matching features into the Nextflow language.
Interesting, it looks similar to the issues they had with Groovy 4.
It looks like one commenter avoided the perf issues by using @CompileStatic and converting code to Java. Since most of the Nextflow codebase is already statically compiled, I suspect we won't be affected as much. But we'll have to run a benchmark to know for sure
The reason will be displayed to describe this comment to others. Learn more.
Based on my limited knowledge of how the Groovy type checker does type inference with instanceof, it seems to be applying the instanceof check incorrectly, treating source as type DataflowWriteChannel through the entire method instead of just the if statement. Likely a Groovy bug
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial attempt to upgrade to Groovy 5.
Benefits:
zip(can be added to Nextflow standard library)instanceof(can be added to Nextflow language)_for placeholder variables (can be added to Nextflow language)Changes:
Had to remove generic type arguments from
instanceofchecks as the Groovy parser doesn't allow it anymoreHad to add
@Slf4jto some inner classes to makelogwork in that class. not sure if this is a bug or just a breaking changeCurrent issues:
Groovy complained about a few implementers of
CacheFunnel, even though I didn't see anything wrong. Converting CacheFunnel to Java fixed the issue for one but not the otherMultiple issues with the type checker that I'm pretty sure are just Groovy bugs, particularly
CmdLogandDumpOpThe type checker does not recognize
targetinTaskConfigas a Map, seems like a bug. I wonder if it's an edge case sincetargetis defined in super class as private and a DelegateOverall it looks like Groovy 5 beta still has a few compiler bugs to sort out. But I'm excited to get it working so that I can bring the new pattern matching features into the Nextflow language.