Skip to content

Conversation

samuell
Copy link
Contributor

@samuell samuell commented Aug 2, 2025

This is a suggested fix for #6127

I have not managed to build and test this with Gradle just yet, but seems it should work based on surrounding code, which does append the .reset() after changing color.

Copy link

netlify bot commented Aug 2, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 1a5cfc0
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/688ddb0a0c699800083d5c56

@samuell samuell force-pushed the 6127-fix-color-reset-in-lint branch from 9d487fc to 1a5cfc0 Compare August 2, 2025 09:31
@bentsherman bentsherman linked an issue Aug 5, 2025 that may be closed by this pull request
@bentsherman bentsherman self-requested a review August 5, 2025 18:37
@bentsherman
Copy link
Member

It might be safer just to reset before the final print instead of handling each case:

        term.reset()
        AnsiConsole.out.print(term)
        AnsiConsole.out.flush()

Does this also work?

@bentsherman bentsherman changed the title Fix #6127: Reset terminal color after lint success/failure message Reset terminal color after lint success/failure message Aug 5, 2025
Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks safe. Thanks for the contribution

@pditommaso pditommaso merged commit 17b05ba into nextflow-io:master Aug 14, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nextflow lint success message does not reset color
3 participants