Move shared Platform code to separate modules#6719
Draft
Conversation
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
pditommaso
reviewed
Jan 13, 2026
Member
|
Thanks @jorgee for looking into this. Let's focus on your codebase analysis for now, as we need to agree on a plan first I suspect if we finalize #5971 and make a few judgement calls, we can make this work with fewer changes. But I need to study your analysis first. Once we agree on a plan, we can add it here as an ADR. |
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
pditommaso
requested changes
Jan 14, 2026
Member
pditommaso
left a comment
There was a problem hiding this comment.
Apart the previous comment, massive PR, well done!
| // create the config | ||
| final config = new ConfigBuilder() | ||
| .setOptions(getLauncher().getOptions()) | ||
| .setCliOptions(getLauncher().getOptions()) |
Member
There was a problem hiding this comment.
Please avoid all not strictly required changes. We can make this kind of refactor in a followup pr
d9fa5cd to
d752bc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces modularization improvements to the Nextflow project and decouples some classes based on the usage of Nexflow classes in Platform
Enhancements
ConfigNodeOption,ConfigRunOptionsandConfigCliOptionsto access the required options fromConfigBuilderwithout requiring the rest ofcliclassesHubOptions, it is now an interface atscmpackage and implement incliasCliHubOptionsNFclass dependency fromConfigBuilderConstas it is just a Environment Variable inspection.ConfigBuilderincludes astrictflag to indicate when to use strict mode when merging maps.HistoryFiledependency fromConfigBuildernormalizeResumeIdtoCmdRun. It is only used when thecmdRunfield is set. Use ConfigRunOptions interface to get the normalized resume id value.secretpackage in the nextflow module andnextflow.util.SecretHelperclass. Depends on nf-commonsconfigpackage in the nextflow module and thenextflow.util.ConfigHelperclass. Depends onnf-secretsandnf-commonsscmpackage in the nextflow module and thenextflow.script.ScriptFileclass. Depends onnf-configandnf-commonsnexflow.executor.BashTemplateandnextflow.util.MustacheTemplateEngine: used by Platformnextflow.ast.NextflowXForm: required by config parsersnextflow.parser.v2.ErrorListener: required byConfigParserV2