Fix JGit resources not being closed in CLI commands#6795
Merged
pditommaso merged 4 commits intomasterfrom Feb 11, 2026
Merged
Conversation
AssetManager now implements Closeable and CLI commands wrap manager usage in try-finally blocks to ensure JGit resources are properly released. This prevents ~90 second shutdown delays caused by JGit shutdown hooks cleaning up unclosed Repository objects. Signed-off-by: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
- Use cached getBareGit() instead of Git.open() in revisionToCommitWithBareRepo() - Cache legacy Git object to avoid repeated unclosed Git.open() calls - Close Git objects returned by clone commands - Wrap FileRepository in try-with-resources in createSharedClone() - Use try-with-resources for RevWalk/TreeWalk in LocalRepositoryProvider Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Contributor
|
In the description I see a part about SCM resource leaks, but I don't see changes in this files. Is there a commit missing? |
Member
Author
|
Yep sorry. Just pushed 4e74582 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssetManagerimplementCloseableinterfaceAssetManagerin all CLI commandsChanges
CLI commands — use auto-closeable
tryto ensureAssetManager.close()is called:CmdRun,CmdPull,CmdView,CmdClone,CmdInfo,CmdConfig,CmdDropSCM resource leaks — fix JGit objects that were never closed:
MultiRevisionRepositoryStrategy.revisionToCommitWithBareRepo(): was callingGit.open()on every invocation without closing — now uses cachedgetBareGit()MultiRevisionRepositoryStrategy.getGit()/getBareGitWithLegacyFallback(): legacy fallback created uncachedGit.open()on every call — added cached_legacyGitfieldMultiRevisionRepositoryStrategy.createBareRepo():Git.cloneRepository().call()returned a Git object that was discarded — now closedMultiRevisionRepositoryStrategy.createSharedClone():FileRepositorywas never closed — wrapped in try-with-resourcesAssetManager.clone():Git.cloneRepository().call()returned a Git object that was discarded — now closedLegacyRepositoryStrategy.download(): sameclone.call()leak — now closedLocalRepositoryProvider.readBytes()/listDirectory():RevWalkandTreeWalkwere not properly closed on all code paths — wrapped in try-with-resourcesTest plan
AssetManagerTest,MultiRevisionRepositoryStrategyTest,LocalRepositoryProviderTest) — all passmake testto verify no regressions