Fix listDirectory() to follow symbolic links#6821
Merged
bentsherman merged 2 commits intomasterfrom Feb 10, 2026
Merged
Conversation
Make listFiles0() parameterized with a followLinks flag so that listFiles() preserves its existing behavior (no symlink following) while listDirectory() follows symbolic links. This avoids the wider blast radius of changing listFiles() behavior which affects task hashing via findBinEntries and other internal callers. Fixes #6807 Generated by Claude Code Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
bentsherman
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listFiles0()parameterized with afollowLinksflag so thatlistDirectory()follows symbolic links whilelistFiles()preserves its existing behaviorlistFiles()behaviorChanges
listFiles0(self, filter, followLinks)— newboolean followLinksparameter (defaultfalse)listFiles()— callslistFiles0without follow links (unchanged behavior)listDirectory()— callslistFiles0withfollowLinks=trueWhy only
listDirectory()?listFiles()is called internally byfindBinEntries,createLinkImpl, andLocalUpdateRepository. Changing its symlink behavior would silently affect task hashing and other internals. SincelistDirectory()is new in 26.04 (#6581), it has no existing callers to break.Fixes #6807
Supersedes #6808
Test plan
listFiles should not follow symlinked directory— verifieslistFiles()preserves old behaviorlistDirectory should follow symlinked directory— verifieslistDirectory()follows symlinksFilesExTesttests pass