Don't include container in task trace when containers are not enabled#6824
Open
bentsherman wants to merge 1 commit intomasterfrom
Open
Don't include container in task trace when containers are not enabled#6824bentsherman wants to merge 1 commit intomasterfrom
bentsherman wants to merge 1 commit intomasterfrom
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Member
|
Worth triggering e2e tests |
bentsherman
force-pushed
the
fix-task-trace-container
branch
2 times, most recently
from
4426b11 to
f90b559
Compare
… [e2e prod] Signed-off-by: Ben Sherman <bentshermann@gmail.com>
bentsherman
force-pushed
the
fix-task-trace-container
branch
from
f90b559 to
f3f1035
Compare
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
d9fa5cd to
d752bc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the task trace to only include the task container if containers were enabled for the run.
This way, when a run uses e.g. conda environments instead of containers, the task detail in Platform won't show a container.