Fix AnsiLogObserver sticky message duplication on line wrap#6852
Merged
pditommaso merged 1 commit intomasterfrom Feb 22, 2026
Merged
Fix AnsiLogObserver sticky message duplication on line wrap#6852pditommaso merged 1 commit intomasterfrom
pditommaso merged 1 commit intomasterfrom
Conversation
Account for terminal line wrapping when counting visual lines in the ANSI progress renderer. Previously only explicit newlines were counted, causing cursorUp to undershoot when messages exceeded terminal width. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ceil(visualLength / cols)per line, after stripping ANSI escape codescountVisualLines(),stripAnsi()methods and corresponding testsTest plan
AnsiLogObserverTesttests passstripAnsiandcountVisualLineswith various wrapping scenarios🤖 Generated with Claude Code