docs: add abdoallah sharaf ambassador profile#368
Merged
mribeirodantas merged 7 commits intonextflow-io:masterfrom Feb 11, 2025
Merged
docs: add abdoallah sharaf ambassador profile#368mribeirodantas merged 7 commits intonextflow-io:masterfrom
mribeirodantas merged 7 commits intonextflow-io:masterfrom
Conversation
Contributor
abdo3a
commented
Feb 6, 2025
abdo3a
commented
✅ Deploy Preview for nextflow-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mribeirodantas
requested changes
Feb 9, 2025
Member
There was a problem hiding this comment.
Hello @abdo3a. I need two things from you before merging this pull request. The first one is to shorten your bio a bit. Currently, it's pushing the social media icons outside the viewable part of the profile box (check below).
The second thing is to upload your picture to public/img folder and refer to its filename in the img field of the AmbassadorCard component. You can see how another ambassador did this in the pull request linked here.
Member
|
@nf-core-bot fix linting |
mribeirodantas
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.