Merged
Conversation
merschformann
requested review from
Copilot,
cowanwalls,
phil-nextmv and
sebastian-quintero
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a basic unit test to verify that CLI flags are parsed into nested option structs by the run.FlagParser.
- Introduces run/flagparser_test.go with a smoke test for iterations, duration, and a nested custom flag.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cowanwalls
reviewed
Oct 3, 2025
Member
cowanwalls
left a comment
cowanwalls
left a comment
There was a problem hiding this comment.
I have questions about this but don't want to block. Setting review as comment for now.
Member
Author
|
Sorry @cowanwalls , you were a bit faster than me fixing the cleanup. 😅 |
cowanwalls
approved these changes
Oct 3, 2025
sebastian-quintero
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a basic test for the flag parser used by the cli runner. The test is a leftover of some debug work, but it might be good to keep it to have some more coverage.
Changes