Doctrine ORM 3.x & DBAL 4.x support#140
Conversation
|
ok, so doctrine run fails. could you fix that please? |
|
Should be fixed now - reverted bool escaping change. |
|
If I see correctly, Doctrine Orm 2.9 was released in 2021-05. If @JanTvrdik does not object, I'm going to merge this. |
|
You need to add this also to https://github.com/nextras/migrations/tree/master/tests/matrix/dbal, otherwise it's not really tested. |
|
DBAL 4.x integration test config added. @JanTvrdik What are your thought on the doctrine/orm min supported version bump? Maybe I should add conflict with older versions into composer.json? |
That's ok.
You can't really have a conflict with optional dependency, because the conflict will prevent install even if the optional feature is not used. |
Configuration::getMetadataCacheImpl()has been dropped in ORM 3.x, but a replacement in the form ofConfiguration::getMetadataCache()is available since ORM 2.9.2.9 has been released in May 2019, IMO it's not worth trying to keep compatibility with ORM <2.9.