Skip to content

Doctrine ORM 3.x & DBAL 4.x support#140

Merged
JanTvrdik merged 4 commits intonextras:masterfrom
xificurk:doctrine-orm-3
Feb 6, 2025
Merged

Doctrine ORM 3.x & DBAL 4.x support#140
JanTvrdik merged 4 commits intonextras:masterfrom
xificurk:doctrine-orm-3

Conversation

@xificurk
Copy link
Copy Markdown
Contributor

@xificurk xificurk commented Feb 3, 2025

Configuration::getMetadataCacheImpl() has been dropped in ORM 3.x, but a replacement in the form of Configuration::getMetadataCache() is available since ORM 2.9.
2.9 has been released in May 2019, IMO it's not worth trying to keep compatibility with ORM <2.9.

@xificurk xificurk changed the title Fix Doctrine ORM 3.x support Doctrine ORM 3.x & DBAL 4.x support Feb 3, 2025
Copy link
Copy Markdown
Member

@hrach hrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's see CI run.

@hrach
Copy link
Copy Markdown
Member

hrach commented Feb 4, 2025

ok, so doctrine run fails. could you fix that please?

@xificurk
Copy link
Copy Markdown
Contributor Author

xificurk commented Feb 4, 2025

Should be fixed now - reverted bool escaping change.

@hrach
Copy link
Copy Markdown
Member

hrach commented Feb 5, 2025

If I see correctly, Doctrine Orm 2.9 was released in 2021-05. If @JanTvrdik does not object, I'm going to merge this.

@JanTvrdik
Copy link
Copy Markdown
Member

You need to add this also to https://github.com/nextras/migrations/tree/master/tests/matrix/dbal, otherwise it's not really tested.

@xificurk
Copy link
Copy Markdown
Contributor Author

xificurk commented Feb 5, 2025

DBAL 4.x integration test config added.

@JanTvrdik What are your thought on the doctrine/orm min supported version bump? Maybe I should add conflict with older versions into composer.json?

@JanTvrdik
Copy link
Copy Markdown
Member

What are your thought on the doctrine/orm min supported version bump?

That's ok.

Maybe I should add conflict with older versions into composer.json?

You can't really have a conflict with optional dependency, because the conflict will prevent install even if the optional feature is not used.

@JanTvrdik JanTvrdik merged commit 1ea7cec into nextras:master Feb 6, 2025
8 checks passed
@xificurk xificurk deleted the doctrine-orm-3 branch February 7, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants