Conversation
'w' is equivalent to 'wt' since the default behavior uses text mode. This is purely for consistency with other usages of open()+json.dump() in scripts, in preparation for an upcoming change.
jameshadfield
approved these changes
Jan 18, 2026
joverlee521
reviewed
Jan 21, 2026
The replacement is part of Augur's public API which comes with more stability and documentation. It will automatically minify large outputs, and will no longer add an entry for "generated_by" Augur version, which didn't make sense in the output of these custom scripts anyways.
augur.io.write_json() will automatically minify large outputs.
victorlin
force-pushed
the
victorlin/use-write_json
branch
from
9b05bae to
2dd1f7d
Compare
joverlee521
approved these changes
Jan 22, 2026
Contributor
|
This should no longer be blocked since nextstrain/augur#1943 was released with Augur 33.0.0. Probably just needs an entry in the changelog? |
Member
Author
|
Done: ncov/docs/src/reference/change_log.md Line 10 in 6802b09 |
victorlin
force-pushed
the
victorlin/use-write_json
branch
from
7a49dae to
6802b09
Compare
Member
Author
|
Oops, the conda runtime check failed because that hasn't been updated with Augur 33.0.0 yet. I've triggered a re-run to fix that. |
Member
|
Thanks for addressing this @victorlin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains 1 prep commit + 2 main commits that switch to use
augur.io.write_json()where appropriate.Closes #1098
Depends on merge and release of nextstrain/augur#1943
Release checklist
If this pull request introduces new features, complete the following steps:
docs/src/reference/change_log.mdin this pull request to document these changes by the date they were added.