Use dynamic routes for /community pages #1285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
nextstrain-s-victorlin--h1u4e8
2 tasks
victorlin
force-pushed
the
victorlin/nested-structure-everywhere
branch
from
ec579d4 to
40e4939
Compare
In practice, not marking it as such has worked fine because the only
usage is with a parent that is a Client Component, meaning it is
implicitly used as one as well.
Not marking it is fragile. Without "use client", using it in a parent
that is a Server Component (done in the next commit) results in a run
time error:
You're importing a component that needs useEffect. It only works in a
Client Component but none of its parents are marked with "use client",
so they're Server Components by default.
This reorganizes files from a flat structure with everything under a catch-all [[...community]] to a nested structure with one directory per URL part. Note that "narratives" is an optional part in the path. Such logic was easily implemented in the custom router by using Array.shift(), but it can't be encoded into dynamic routes. As a result, there is some boilerplate duplication between community/[user]/ and narratives/[user]/, but the bulk of the content remains in the top-level community/*.tsx files.
The new file structure makes it clear that this component is only used when there is no repo in the URL path.
victorlin
force-pushed
the
victorlin/nested-structure-community
branch
from
44da889 to
e7abe5a
Compare
Base automatically changed from
victorlin/nested-structure-everywhere
to
master
December 10, 2025 17:28
victorlin
commented
Dec 11, 2025
Comment on lines
-33
to
-40
| * Note that the 404 status codes are being set/returned at the | ||
| * Express router code, as a side effect of how that code re-directs | ||
| * requests that don't directly load a dataset or narrative into the | ||
| * Next.js part of the web site. This router code does not make use of | ||
| * the Next.js `notFound()` method because the 404 status has already | ||
| * been set. For the requests that don't display an <ErrorMessage>, | ||
| * the status should _arguably_ be 200, but I'm not going to worry | ||
| * about that at the moment. - @genehack, 1 Aug 2025 |
Member
Author
There was a problem hiding this comment.
Note on previous implementation: this isn't entirely true. 404 is only returned for some routes, and never for text/html. Examples:
curl -I "https://nextstrain.org/community/invalid"
# 200
curl -I "https://nextstrain.org/community/user/invalid"
# 404
curl -I "https://nextstrain.org/community/user/invalid" -H 'accept: text/html'
# 200
curl -I "https://nextstrain.org/community/user/repo/invalid"
# 404
curl -I "https://nextstrain.org/community/user/repo/invalid" -H 'accept: text/html'
# 200This contrasts with /staging which returns 404 for text/html:
curl -I "https://nextstrain.org/staging/invalid" -H 'accept: text/html'
# 404
Member
Author
There was a problem hiding this comment.
I considered adding another commit to send proper 404 responses, primarily to address the related testing comment. That was fairly straightforward for https://nextstrain.org/community/user/repo/invalid: 259d795
However, it's complicated for https://nextstrain.org/community/user/invalid which relies on a client-side fetch to /charon to determine whether the repo exists and is public. The fetch could be moved server-side, but I didn't want to deal with that in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR has (in order) 1 cleanup/prep commit, 1 main commit, and 1 follow-up commit.
The main commit reorganizes files from a flat structure with everything under a catch-all [[...community]] to a nested structure with one directory per URL part.
Note that "narratives" is an optional part in the path. Such logic was easily implemented in the custom router by using Array.shift(), but it can't be encoded into dynamic routes. As a result, there is some boilerplate duplication between community/[user]/ and narratives/[user]/, but the bulk of the content remains in the top-level community/*.tsx files.
Related issue(s)
Follow-up to #1274
Checklist