Restore group name filtering #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
nextstrain-s-victorlin--b2gytt
joverlee521
approved these changes
Jan 5, 2026
Contributor
There was a problem hiding this comment.
The group name filtering doesn't work in the test app, but I think that's due to there only being a single group in the test env. Worked as expected when I tested locally.
Edit: Yup, the group name filter does not work when there's only a single group since options filter out search options present in every resource.
The commit "Strip group name in resource list" (c7b4498) had the unintended side effect of removing the group name from filter options. This is a follow-up that keeps the visual change while allowing group names to be used in filtering. It is accomplished by adding a resource-level property to control which name parts are displayed, using that to hide the first name part on the groups page.
victorlin
force-pushed
the
victorlin/filter-group-name
branch
from
8fa57bc to
7b8ffec
Compare
jameshadfield
approved these changes
Jan 5, 2026
joverlee521
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The commit "Strip group name in resource list" (c7b4498) had the unintended side effect of removing the group name from filter options.
This is a follow-up that keeps the visual change while allowing group names to be used in filtering. It is accomplished by adding a resource-level property to control which name parts are displayed, using that to hide the first name part on the groups page.
Related issue(s)
Closes #1286
Checklist