Closed
Conversation
cb2e978 to
fcda4b1
Compare
a26269f to
7e76787
Compare
fcda4b1 to
ceed6b8
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With our move away from fauna and to a curated all-influenza ingest pipeline we have introduced a number of strain name changes. This immediately presents a problem as we have myriad lists of hardcoded strain names, such as outliers-to-drop and force-include-lists. This workflow (which is rather ad-hoc!) attempts to match up the old (i.e. fauna) strain names with their updated strain names.
We use a combination of fuzzy-matching and a hardcoded map of fauna strain names to new strain names.
See added readme for how to run (not very user friendly at the moment!)
Hardcoded strain maps
For seasonal-flu datasets we can query the EPI_ISLs of the fauna data against the curated data to create lookups.
This table reports how many of the fauna strain names have matches in our data. For avian-flu it's a little tricker so we leverage the existing diff-avian-flu script to create lookups.
Example results
Not able to be matched:
A/Environment/InnerMongolia/23285/2019is nowA/Environment/Neimenggu/23285/2019(the location change is via this fauna TSV.Automatically matched:
A/Indiana/08/2012remapped toA/Indiana/8/2012via fuzzy matching (this looks right)A/India/3/2019remapped toA/Indiana/3/2019via fuzzy matching (this is wrong!)Full Results
cc @joverlee521 - you may want to adapt this for titers matching?