Skip to content

Tweak tip_frequencies arguments [#33]#34

Merged
genehack merged 2 commits intomainfrom
tweak-freq-panel-params-33
Mar 25, 2025
Merged

Tweak tip_frequencies arguments [#33]#34
genehack merged 2 commits intomainfrom
tweak-freq-panel-params-33

Conversation

@genehack
Copy link
Contributor

Description of proposed changes

Updating per @huddlej's advice

  • remove max_date
  • reduce narrow_bandwidth to 1 month
  • reduce wide_bandwidth to 3 months
  • add proportion_wide argument

New builds uploaded to staging

Related issue(s)

Closes #33

Checklist

  • Checks pass

* remove `max_date`
* reduce `narrow_bandwidth` to 1 month
* reduce `wide_bandwidth` to 3 months
* add `proportion_wide` argument
@genehack genehack requested a review from huddlej March 24, 2025 21:15
Copy link

@huddlej huddlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The only other change I'd recommend trying is to add a config parameter/frequencies argument for the pivot interval (--pivot-interval) and set the value to 1. The default pivot interval is 3 months which is part of why the builds on staging have such quick transitions between high and low frequency lineages without any intermediate states.

The H3N2 HA 6-year build shows a similar time span but using a 1-month pivot interval which gives you more resolution. The flu dataset has >15 times as many samples as the YFV dataset, so you'll probably still get noisier estimates at the monthly intervals than you see in the flu data.

@genehack
Copy link
Contributor Author

Nice! The only other change I'd recommend trying is to add a config parameter/frequencies argument for the pivot interval (--pivot-interval) and set the value to 1. The default pivot interval is 3 months which is part of why the builds on staging have such quick transitions between high and low frequency lineages without any intermediate states.

Ah, thanks, that did help smooth things out a bit — the staging builds have been updated.

@genehack genehack merged commit dcd5ec1 into main Mar 25, 2025
5 checks passed
@genehack genehack deleted the tweak-freq-panel-params-33 branch March 25, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust frequencies panel parameters

2 participants