Open
Conversation
…ropriate parent classes.
… hierarchical namespaces
Open
lukaspie
pushed a commit
to FAIRmat-NFDI/NeXusOntology
that referenced
this pull request
Dec 16, 2025
lukaspie
force-pushed
the
oscars-project
branch
from
59e6239 to
8de5550
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces significant updates and improvements to the NeXusOntology project:
Extension of Application Classes
Refactored NeXusOntology.py to extend Application classes to appropriate parent classes, improving inheritance structure and maintainability.
OWL File Generation
Updated logic to generate OWL files using the commit hash from the definitions submodule, ensuring reproducible ontology builds tied to specific definitions versions.
Dual Usage for Ontology Generator
Harmonized generate_ontology.py to support both import as a module and execution as a standalone script, increasing flexibility for developers and automation workflows.
Category and Enum Fixes
Fixed disjointness for Unit Categories, and addressed handling for open enums to improve ontology consistency and correctness.