Skip to content

Commit da9653a

Browse files
authored
Merge pull request #79 from drpatelh/master
Bug fixes
2 parents dc2f798 + 5d2d7b5 commit da9653a

File tree

7 files changed

+102
-52
lines changed

7 files changed

+102
-52
lines changed

README.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,12 @@ The nf-core/chipseq pipeline comes with documentation about the pipeline, found
5757
## Credits
5858
These scripts were written for use at the [National Genomics Infrastructure](https://portal.scilifelab.se/genomics/)
5959
at [SciLifeLab](http://www.scilifelab.se/) in Stockholm, Sweden.
60-
Originally written by Chuan Wang ([@chuan-wang](https://github.com/chuan-wang)) and Phil Ewels ([@ewels](https://github.com/ewels)), and re-implemented by Harshil Patel ([@drpatelh](https://github.com/drpatelh)) from the [The Bioinformatics & Biostatistics Group](https://www.crick.ac.uk/research/science-technology-platforms/bioinformatics-and-biostatistics/) at [The Francis Crick Institute](https://www.crick.ac.uk/), London.
60+
Originally written by Chuan Wang ([@chuan-wang](https://github.com/chuan-wang)) and Phil Ewels ([@ewels](https://github.com/ewels)), and re-implemented by Harshil Patel ([@drpatelh](https://github.com/drpatelh)) from [The Bioinformatics & Biostatistics Group](https://www.crick.ac.uk/research/science-technology-platforms/bioinformatics-and-biostatistics/) at [The Francis Crick Institute](https://www.crick.ac.uk/), London.
61+
62+
## Citation
63+
64+
<!-- TODO nf-core: Add citation for pipeline after release. Uncomment lines below and add citation. -->
65+
<!-- If you use nf-core/chipseq for your analysis, please cite it as follows: -->
66+
67+
You can cite the `nf-core` pre-print as follows:
68+
Ewels PA, Peltzer A, Fillinger S, Alneberg JA, Patel H, Wilm A, Garcia MU, Di Tommaso P, Nahnsen S. **nf-core: Community curated bioinformatics pipelines**. *bioRxiv*. 2019. p. 610741. [doi: 10.1101/610741](https://www.biorxiv.org/content/10.1101/610741v1).

assets/multiqc_config.yaml

Lines changed: 0 additions & 9 deletions
This file was deleted.

bin/check_design.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -79,16 +79,6 @@ def reformat_design(DesignFile,ReadMappingFile,ControlMappingFile):
7979
print "{}: FastQ file has incorrect extension (has to be '.fastq.gz' or 'fq.gz') - {}\nLine: '{}'".format(ERROR_STR,fastq,line.strip())
8080
sys.exit(1)
8181

82-
## CHECK FASTQ FILES EXIST PER SAMPLE
83-
if fastq[:4] not in ['http']:
84-
if not os.path.exists(fastq):
85-
print "{}: FastQ file does not exist - {}\nLine: '{}'".format(ERROR_STR,fastq,line.strip())
86-
sys.exit(1)
87-
else:
88-
if requests.head(fastq).status_code >= 400:
89-
print "{}: FastQ file does not exist - {}\nLine: '{}'".format(ERROR_STR,fastq,line.strip())
90-
sys.exit(1)
91-
9282
## CREATE GROUP MAPPING DICT = {GROUP_ID: {REPLICATE_ID:[[FASTQ_FILES]]}
9383
if not sampleMappingDict.has_key(group):
9484
sampleMappingDict[group] = {}

docs/output.md

Lines changed: 59 additions & 23 deletions
Large diffs are not rendered by default.

docs/usage.md

Lines changed: 28 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@
1414
* [`--design`](#--design)
1515
* [Generic arguments](#generic-arguments)
1616
* [`--singleEnd`](#--singleend)
17-
* [`--narrowPeak`](#--narrowpeak)
17+
* [`--seqCenter`](#--seqcenter)
1818
* [`--fragment_size`](#--fragment_size)
19+
* [`--fingerprintBins`](#--fingerprintbins)
1920
* [Reference genomes](#reference-genomes)
2021
* [`--genome` (using iGenomes)](#--genome-using-igenomes)
2122
* [`--fasta`](#--fasta)
@@ -34,6 +35,11 @@
3435
* [`--keepDups`](#--keepdups)
3536
* [`--keepMultiMap`](#--keepmultimap)
3637
* [`--saveAlignedIntermediates`](#--savealignedintermediates)
38+
* [Peaks](#peaks)
39+
* [`--narrowPeak`](#--narrowpeak)
40+
* [`--broad_cutoff`](#--broad_cutoff)
41+
* [`--saveMACSPileup`](#--savemacspileup)
42+
* [`--skipDiffAnalysis`](#--skipdiffanalysis)
3743
* [Job resources](#job-resources)
3844
* [Automatic resubmission](#automatic-resubmission)
3945
* [Custom resource requests](#custom-resource-requests)
@@ -184,12 +190,17 @@ By default, the pipeline expects paired-end data. If you have single-end data, s
184190

185191
It is not possible to run a mixture of single-end and paired-end files in one run.
186192

187-
### `--narrowPeak`
188-
MACS2 is run by default with the [`--broad`](https://github.com/taoliu/MACS#--broad) flag. Specify this flag to call peaks in narrowPeak mode.
193+
### `--seqCenter`
194+
Sequencing center information that will be added to read groups in BAM files.
189195

190196
### `--fragment_size`
191197
Number of base pairs to extend single-end reads when creating bigWig files. Default: `0`
192198

199+
### `--fingerprintBins`
200+
Number of genomic bins to use when generating the deepTools fingerprint plot. Larger numbers will give a smoother profile, but take longer to run.
201+
202+
Default: `500000`
203+
193204
## Reference genomes
194205

195206
The pipeline config files come bundled with paths to the illumina iGenomes reference index files. If running with docker or AWS, the configuration is set up to use the [AWS-iGenomes](https://ewels.github.io/AWS-iGenomes/) resource.
@@ -310,6 +321,20 @@ Reads mapping to multiple locations in the genome are not filtered from alignmen
310321
### `--saveAlignedIntermediates`
311322
By default, intermediate BAM files will not be saved. The final BAM files created after the appropriate filtering step are always saved to limit storage usage. Set to true to also save other intermediate BAM files.
312323

324+
## Peaks
325+
326+
### `--narrowPeak`
327+
MACS2 is run by default with the [`--broad`](https://github.com/taoliu/MACS#--broad) flag. Specify this flag to call peaks in narrowPeak mode.
328+
329+
### `--broad_cutoff`
330+
Specifies broad cutoff value for MACS2. Only used when --narrowPeak isnt specified. Default: 0.1
331+
332+
### `--saveMACSPileup`
333+
Instruct MACS2 to create bedGraph files using the `-B --SPMR` parameters.
334+
335+
### `--skipDiffAnalysis`
336+
Skip read counting and differential analysis step.
337+
313338
## Job resources
314339
### Automatic resubmission
315340
Each step in the pipeline has a default set of requirements for number of CPUs, memory and time. For most of the steps in the pipeline, if the job exits with an error code of `143` (exceeded requested resources) it will automatically resubmit with higher requests (2 x original, then 3 x original). If it still fails after three times then the pipeline is stopped.

main.nf

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ def helpMessage() {
2626
Available: conda, docker, singularity, awsbatch, test
2727
2828
Generic
29-
--genome Name of iGenomes reference
3029
--singleEnd Specifies that the input is single-end reads
3130
--seqCenter Sequencing center information to be added to read group of BAM files
3231
--fragment_size [int] Estimated fragment size used to extend single-end reads. Default: 0
3332
--fingerprintBins Number of genomic bins to use when calculating fingerprint plot. Default: 500000
3433
3534
References If not specified in the configuration file or you wish to overwrite any of the references
35+
--genome Name of iGenomes reference
3636
--bwa_index Full path to directory containing BWA index including base name i.e. /path/to/index/genome.fa
3737
--gene_bed Path to BED file containing gene intervals
3838
--tss_bed Path to BED file containing transcription start sites
@@ -320,7 +320,7 @@ if (params.singleEnd) {
320320
if (!params.bwa_index){
321321
process makeBWAindex {
322322
tag "$fasta"
323-
label 'process_big'
323+
label 'process_high'
324324
publishDir path: { params.saveGenomeIndex ? "${params.outdir}/reference_genome" : params.outdir },
325325
saveAs: { params.saveGenomeIndex ? it : null }, mode: 'copy'
326326

@@ -515,7 +515,7 @@ if (params.skipTrimming){
515515
*/
516516
process bwaMEM {
517517
tag "$name"
518-
label 'process_big'
518+
label 'process_high'
519519

520520
input:
521521
set val(name), file(reads) from ch_trimmed_reads
@@ -861,7 +861,7 @@ process bigWig {
861861
*/
862862
process plotProfile {
863863
tag "$name"
864-
label 'process_big'
864+
label 'process_high'
865865
publishDir "${params.outdir}/bwa/mergedLibrary/deepTools/plotProfile", mode: 'copy'
866866

867867
input:
@@ -1062,7 +1062,7 @@ process peakQC {
10621062
*/
10631063
process plotFingerprint {
10641064
tag "${ip} vs ${control}"
1065-
label 'process_big'
1065+
label 'process_high'
10661066
publishDir "${params.outdir}/bwa/mergedLibrary/deepTools/plotFingerprint", mode: 'copy'
10671067

10681068
input:

nextflow.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@
99
params {
1010

1111
// Options: Generic
12-
genome = false
1312
singleEnd = false
1413
seqCenter = false
1514
fragment_size = 0
1615
fingerprintBins = 500000
1716

1817
// Options: References
18+
genome = false
1919
tss_bed = false
2020
saveGenomeIndex = false
2121

0 commit comments

Comments
 (0)