Skip to content

Newcastle#961

Open
chriswyatt1 wants to merge 4 commits intonf-core:masterfrom
chriswyatt1:newcastle
Open

Newcastle#961
chriswyatt1 wants to merge 4 commits intonf-core:masterfrom
chriswyatt1:newcastle

Conversation

@chriswyatt1
Copy link
Contributor


name: New Config
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

scratch = true
errorStrategy = { task.exitStatus in [137, 140] ? 'retry' : 'finish' }
queue = 'defq' // maps to `#SBATCH -p defq`
clusterOptions = '--account=DESIM' // maps to `#SBATCH -A DESIM`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, this works for every single user of the cluster?


process {
scratch = true
errorStrategy = { task.exitStatus in [137, 140] ? 'retry' : 'finish' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should already be in nf-core pipelines, but with an improved range: https://github.com/nf-core/tools/blob/75e643ad2c62cdc8ecd39aa56c0c314efd4b13e4/nf_core/pipeline-template/conf/base.config#L18

If you are adding this for non-official nf-core pipelines, I would recommend at least to match the nf-core one.

@@ -0,0 +1,46 @@
# nf-core/configs: Newcastle HPC Configuration

Configuration for the Newcastle high performance computing (HPC) cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this University of Newcastle?

params {
config_profile_description = 'Newcastle HPC cluster profile'
config_profile_contact = 'Chris Wyatt (@chriswyatt1), Fernando Duarte (@FernandoDuarteF)'
config_profile_url = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing URL of cluster or instituteion

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have no resource limits specified, are there no limits?

@chriswyatt1
Copy link
Contributor Author

Thanks James. We will speak to the HPC admins this week at Newcastle University (UK). To ensure all those issues are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants