Skip to content

Conversation

@LaurenceKuhl
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/crisprseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! This should be fixed in the nf-core/modules repo, since it is an nf-core module. Then we can update the module in the pipeline :)

@matbonfanti matbonfanti added this to the 3.0.0 milestone Mar 5, 2025
@LaurenceKuhl
Copy link
Contributor Author

i also wonder why the tests run in our screening tests + in the nf-core modules repo so i wonder if this change is needed and/or why a user had this error

@mirpedrol
Copy link
Member

we are not testing with conda here, only on PRs to master, so we could check the conda tests.
It could also be specific to the user who had this error, we should check on their environment.

@matbonfanti matbonfanti removed this from the 3.0.0 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants