Skip to content

POC: replace webhook notifications with nf-slack plugin #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

POC: replace webhook notifications with nf-slack plugin #46

wants to merge 5 commits into from
+14 −179

Conversation

@adamrtalbot
Copy link

@adamrtalbot adamrtalbot commented Oct 29, 2025 •
edited
Loading

Replace the custom webhook-based instant message system with the
nf-slack plugin for improved Slack notifications. This change provides
automatic workflow lifecycle notifications with enhanced features.

Changes:

  • Add nf-slack plugin (v0.1.0) to nextflow.config
  • Configure automatic notifications for start, complete, and error events
  • Remove custom imNotification function and webhook templates
  • Remove hook_url parameter from pipeline configuration
  • Update README with Slack notification setup instructions

Benefits:

  • Automatic notifications without manual coding
  • Built-in support for resource usage statistics
  • Fail-safe operation that never fails the workflow
  • Cleaner codebase with ~60 lines of code removed

🤖 Generated with Claude Code

Co-Authored-By: Claude [email protected]

vdauwera and others added 3 commits June 4, 2025 10:38
@vdauwera
Minor fixes and template update
16bb0e3 
Merge pull request #32 from nf-core/dev
@FloWuenne
Merge pull request #42 from nf-core/dev
db7f526 
Dev to Master for release 1.0.2
@adamrtalbot @claude
feat: replace webhook notifications with nf-slack plugin
22e42da 
Replace the custom webhook-based instant message system with the
nf-slack plugin for improved Slack notifications. This change provides
automatic workflow lifecycle notifications with enhanced features.

Changes:
- Add nf-slack plugin (v0.1.0) to nextflow.config
- Configure automatic notifications for start, complete, and error events
- Remove custom imNotification function and webhook templates
- Remove hook_url parameter from pipeline configuration
- Update README with Slack notification setup instructions

Benefits:
- Automatic notifications without manual coding
- Built-in support for resource usage statistics
- Fail-safe operation that never fails the workflow
- Cleaner codebase with ~60 lines of code removed

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@github-actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @adamrtalbot,

It looks like this pull-request is has been made against the nf-core/demo master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/demo dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@adamrtalbot adamrtalbot changed the base branch from master to dev October 29, 2025 15:47
@github-actions
Copy link

github-actions bot commented Oct 29, 2025 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit fb39227

+| ✅ 204 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 3.3.1
  • Run at 2025-10-29 16:03:37

@github-actions
Copy link

nf-core pipelines lint overall result: Failed ❌

Posted for pipeline commit 22e42da

+| ✅ 205 tests passed       |+
!| ❗   2 tests had warnings |!
-| ❌   1 tests failed       |-

❌ Test failures:

  • rocrate_readme_sync - The RO-Crate descriptions do not match the README.md content. Use nf-core lint --fix rocrate_readme_sync to update.

❗ Test warnings:

  • schema_lint - Input mimetype is missing or empty
  • included_configs - Pipeline config does not include custom configs. Please add the includeConfig line.

✅ Tests passed:

Run details

  • nf-core/tools version 3.3.1
  • Run at 2025-10-29 15:47:55

@adamrtalbot adamrtalbot changed the title feat: replace webhook notifications with nf-slack plugin POC: replace webhook notifications with nf-slack plugin Oct 29, 2025
@adamrtalbot adamrtalbot marked this pull request as draft October 29, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adamrtalbot @vdauwera @FloWuenne