Conversation
|
d4straub
left a comment
There was a problem hiding this comment.
Just a few comments. Looks like huge success on test!
| [](https://cloud.seqera.io/launch?pipeline=https://github.com/nf-core/lsmquant) | ||
|
|
||
| [](https://nfcore.slack.com/channels/lsmquant)[](https://bsky.app/profile/nf-co.re)[](https://mstdn.science/@nf_core)[](https://www.youtube.com/c/nf-core) | ||
|  |
There was a problem hiding this comment.
I got an email that says:
[...] The selected style seems to affect the size.
To fix that, please remove the 'style=plastic&' from the link to the badge's image (retaining the leading '?')

Not sure if thats really an improvement though
There was a problem hiding this comment.
will change it in the next PR :)
There was a problem hiding this comment.
thats a module test, not a pipeline test, isnt it? Because the title of the PR is "pipeline level test" ...
There was a problem hiding this comment.
Yes its a module test. Yes, the intention of the PR was to update pipeline level tests ( adding + updating). Then i had some issues and on the way fixing them i started to fix other issues that i oversaw or forgot 🫣
There was a problem hiding this comment.
I find it admirable that you have meta.yml and .nf.test files for local modules and subworkflows, are you planning to add those to nf-core/modules or subsowrkflows? Because it seems like a fairly small step from here?
There was a problem hiding this comment.
Hm good question. My initial plan was not to. I just wanted to stick to the convention 😅
Thank you so much for your review and taking the time to look at it! 🙏 |
…es + removed unused container options in test.config
adding pipeline level tests, default.nf.test running the complete workflow (preprocessing + unet quantification on gpu)
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).