Skip to content

update pipeline level test#26

Merged
CaroAMN merged 27 commits intonf-core:devfrom
CaroAMN:dev
Sep 22, 2025
Merged

update pipeline level test#26
CaroAMN merged 27 commits intonf-core:devfrom
CaroAMN:dev

Conversation

@CaroAMN
Copy link
Collaborator

@CaroAMN CaroAMN commented Aug 27, 2025

adding pipeline level tests, default.nf.test running the complete workflow (preprocessing + unet quantification on gpu)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/lsmquant branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@CaroAMN
Copy link
Collaborator Author

CaroAMN commented Sep 5, 2025

  • nf-test runs locally with singularity with the same command as on ci ( same profiles)
  • pipeline runs with test and gpu profile with singularity locally
  • nf-test for the numorph3dunet module passes on ci with singularity, gpu and small test dataset ( no stub run)

Copy link

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. Looks like huge success on test!

[![Launch on Seqera Platform](https://img.shields.io/badge/Launch%20%F0%9F%9A%80-Seqera%20Platform-%234256e7)](https://cloud.seqera.io/launch?pipeline=https://github.com/nf-core/lsmquant)

[![Get help on Slack](http://img.shields.io/badge/slack-nf--core%20%23lsmquant-4A154B?labelColor=000000&logo=slack)](https://nfcore.slack.com/channels/lsmquant)[![Follow on Bluesky](https://img.shields.io/badge/bluesky-%40nf__core-1185fe?labelColor=000000&logo=bluesky)](https://bsky.app/profile/nf-co.re)[![Follow on Mastodon](https://img.shields.io/badge/mastodon-nf__core-6364ff?labelColor=FFFFFF&logo=mastodon)](https://mstdn.science/@nf_core)[![Watch on YouTube](http://img.shields.io/badge/youtube-nf--core-FF0000?labelColor=000000&logo=youtube)](https://www.youtube.com/c/nf-core)
![HiRSE Code Promo Badge](https://img.shields.io/badge/Promo-8db427?style=plastic&label=HiRSE&labelColor=005aa0&link=https%3A%2F%2Fgo.fzj.de%2FCodePromo)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got an email that says:

[...] The selected style seems to affect the size.
To fix that, please remove the 'style=plastic&' from the link to the badge's image (retaining the leading '?')
![HiRSE Code Promo Badge](https://img.shields.io/badge/Promo-8db427?label=HiRSE&labelColor=005aa0&link=https%3A%2F%2Fgo.fzj.de%2FCodePromo)

Not sure if thats really an improvement though

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will change it in the next PR :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats a module test, not a pipeline test, isnt it? Because the title of the PR is "pipeline level test" ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes its a module test. Yes, the intention of the PR was to update pipeline level tests ( adding + updating). Then i had some issues and on the way fixing them i started to fix other issues that i oversaw or forgot 🫣

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it admirable that you have meta.yml and .nf.test files for local modules and subworkflows, are you planning to add those to nf-core/modules or subsowrkflows? Because it seems like a fairly small step from here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm good question. My initial plan was not to. I just wanted to stick to the convention 😅

@CaroAMN
Copy link
Collaborator Author

CaroAMN commented Sep 22, 2025

Just a few comments. Looks like huge success on test!

Thank you so much for your review and taking the time to look at it! 🙏

…es + removed unused container options in test.config
@CaroAMN CaroAMN merged commit debb80e into nf-core:dev Sep 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants