Skip to content

Conversation

@jonasscheid
Copy link
Collaborator

@jonasscheid jonasscheid commented Jan 8, 2026

Merge after #429

Nf-core module topic channel merge should be the next step. I did migrate to topic channels in pipeline nf-core modules for consistency reasons.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mhcquant branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d7a9324

+| ✅ 300 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   3 tests had warnings |!
Details

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.1
  • Run at 2026-01-29 10:06:30

Updated CHANGELOG for version 3.2.0 with changes and dependency updates.
Copy link
Contributor

Copilot AI commented Jan 9, 2026

@jonasscheid I've opened a new pull request, #433, to work on those changes. Once the pull request is ready, I'll request review from you.

@jonasscheid jonasscheid changed the title Migrate to topic channels Migrate to topic channels for versions Jan 9, 2026
Copy link

@Joon-Klaps Joon-Klaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% certain if everything went ok with template merge.

Think you might to fix of couple stuff first before the linter will be happy.

@jonasscheid
Copy link
Collaborator Author

jonasscheid commented Jan 28, 2026

@Joon-Klaps Thanks already for having a look! I updated every nf-core module to topics as well. Made the linter happy. Currently tests fail due to sever issue of a tool that we are dependent on. Should resolve itself after 1,2 tries. If you could have a look again, I would be grateful :)

EDIT: Seems to be a mqc issue. On it!

EDIT EDIT: Fixed 👍🏼

Copy link

@Joon-Klaps Joon-Klaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you still missed some stuff, mostly regarding the topics themselves

@nf-core nf-core deleted a comment from Joon-Klaps Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants