-
Notifications
You must be signed in to change notification settings - Fork 32
Migrate to topic channels for versions #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Updated CHANGELOG for version 3.2.0 with changes and dependency updates.
|
@jonasscheid I've opened a new pull request, #433, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: jonasscheid <[email protected]>
Remove cache buster artifacts from topic channel migration
Joon-Klaps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% certain if everything went ok with template merge.
Think you might to fix of couple stuff first before the linter will be happy.
|
@Joon-Klaps Thanks already for having a look! I updated every nf-core module to topics as well. Made the linter happy. Currently tests fail due to sever issue of a tool that we are dependent on. Should resolve itself after 1,2 tries. If you could have a look again, I would be grateful :) EDIT: Seems to be a mqc issue. On it! EDIT EDIT: Fixed 👍🏼 |
Joon-Klaps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think you still missed some stuff, mostly regarding the topics themselves
Co-authored-by: Joon Klaps <[email protected]>
Co-authored-by: Joon Klaps <[email protected]>
Co-authored-by: Joon Klaps <[email protected]>
Co-authored-by: Joon Klaps <[email protected]>
Co-authored-by: Joon Klaps <[email protected]>
Co-authored-by: Joon Klaps <[email protected]>
Merge after #429
Nf-core module topic channel merge should be the next step. I did migrate to topic channels in pipeline nf-core modules for consistency reasons.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).