-
Notifications
You must be signed in to change notification settings - Fork 9
Refactor tests #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests #163
Conversation
Content validation is done internally in the pixelator package
fbdtemme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Only thing I am unsure about is the test scripts. I have not really seen any custom scripts being used in other nf-core repos so maybe the core folks would have issues with that?
I would just leave those out.
|
Maybe it is something to bring to the table and hear what the nf-core folks think about it? Since testing seems to be a pain point for main pipeline as I understand it. |
|
I can ask on slack and fix it in a new PR if I get any suggestions, thanks for the review! |
This is the second attempt to make it easier and faster to use the tests when developing the pipeline (first attempt was PR #161)
This PR does the following:
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).CHANGELOG.mdis updated.