Skip to content

Fix behavior when no fusion is present#714

Merged
rannick merged 40 commits intodevfrom
no_fusions
Sep 9, 2025
Merged

Fix behavior when no fusion is present#714
rannick merged 40 commits intodevfrom
no_fusions

Conversation

@rannick
Copy link
Copy Markdown
Collaborator

@rannick rannick commented Jul 16, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnafusion branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 16, 2025

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.2.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 16, 2025

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2c710b6

+| ✅ 307 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   2 tests had warnings |!
Details

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config

❔ Tests ignored:

  • files_exist - File is ignored: tests/default.nf.test
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 3.3.2
  • Run at 2025-09-09 12:47:50

@rannick rannick marked this pull request as ready for review July 16, 2025 08:06
@rannick rannick marked this pull request as draft July 16, 2025 08:06
@rannick rannick changed the base branch from master to dev July 16, 2025 12:10
@rannick rannick self-assigned this Jul 17, 2025
@rannick
Copy link
Copy Markdown
Collaborator Author

rannick commented Jul 17, 2025

Waiting for test to finish

Copy link
Copy Markdown
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, why did you delete the test snapshot though?

rannick and others added 7 commits September 2, 2025 10:27
Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
@rannick rannick marked this pull request as ready for review September 9, 2025 12:37
@rannick rannick requested a review from atrigila as a code owner September 9, 2025 12:37
Copy link
Copy Markdown
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rannick rannick merged commit b1c222c into dev Sep 9, 2025
20 checks passed
@rannick rannick deleted the no_fusions branch September 9, 2025 13:42
@atrigila atrigila mentioned this pull request Sep 16, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants