Fix vcf-collect filter when fusions are missing from fusioninspector#786
Merged
nvnieuwk merged 8 commits intonf-core:devfrom Jan 9, 2026
Merged
Fix vcf-collect filter when fusions are missing from fusioninspector#786nvnieuwk merged 8 commits intonf-core:devfrom
nvnieuwk merged 8 commits intonf-core:devfrom
Conversation
Member
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.3.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
atrigila
approved these changes
Jan 8, 2026
Contributor
atrigila
left a comment
atrigila
left a comment
There was a problem hiding this comment.
This makes sense to me.
Contributor
Author
|
I'm going to run a full test first before merging this, but thanks for the review! |
Contributor
Author
|
This seems to work perfectly now! I'll merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fusions where not correctly annotated when they were missing from the fusioninspector input. The annotations are fixed by adjusting this filter check