Skip to content

Commit cd97466

Browse files
authored
Merge pull request #96 from Patricie34/dev
Added missing citations to citation tool
2 parents 487f081 + 7ca4053 commit cd97466

File tree

2 files changed

+17
-21
lines changed

2 files changed

+17
-21
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ Initial release of nf-core/seqinspector, created with the [nf-core](https://nf-c
1919
- [#51](https://github.com/nf-core/seqinspector/pull/51) Add nf-test to CI.
2020
- [#63](https://github.com/nf-core/seqinspector/pull/63) Contribution guidelines added about displaying results for new tools
2121
- [#53](https://github.com/nf-core/seqinspector/pull/53) Add FastQ-Screen database multiplexing and limit scope of nf-test in CI.
22+
- [#96](https://github.com/nf-core/seqinspector/pull/96) Added missing citations to citation tool
2223

2324
### `Fixed`
2425

subworkflows/local/utils_nfcore_seqinspector_pipeline/main.nf

Lines changed: 16 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -229,27 +229,27 @@ def genomeExistsError() {
229229
// Generate methods description for MultiQC
230230
//
231231
def toolCitationText() {
232-
// TODO nf-core: Optionally add in-text citation tools to this list.
233-
// Can use ternary operators to dynamically construct based conditions, e.g. params["run_xyz"] ? "Tool (Foo et al. 2023)" : "",
234-
// Uncomment function in methodsDescriptionText to render in MultiQC report
235232
def citation_text = [
236-
"Tools used in the workflow included:",
237-
"FastQC (Andrews 2010),",
238-
"MultiQC (Ewels et al. 2016)",
239-
"."
240-
].join(' ').trim()
233+
"Tools used in the workflow included:",
234+
"FastQC (Andrews 2010),",
235+
"MultiQC (Ewels et al. 2016),",
236+
"FastQ Screen (Wingett & Andrews 2018)",
237+
params.sample_size > 0 ? "Seqtk (Li 2021)," : "",
238+
"SeqFu (Telatin et al. 2021),",
239+
"."
240+
].join(' ').trim()
241241

242242
return citation_text
243243
}
244244

245245
def toolBibliographyText() {
246-
// TODO nf-core: Optionally add bibliographic entries to this list.
247-
// Can use ternary operators to dynamically construct based conditions, e.g. params["run_xyz"] ? "<li>Author (2023) Pub name, Journal, DOI</li>" : "",
248-
// Uncomment function in methodsDescriptionText to render in MultiQC report
249246
def reference_text = [
250-
"<li>Andrews S, (2010) FastQC, URL: https://www.bioinformatics.babraham.ac.uk/projects/fastqc/).</li>",
251-
"<li>Ewels, P., Magnusson, M., Lundin, S., & Käller, M. (2016). MultiQC: summarize analysis results for multiple tools and samples in a single report. Bioinformatics , 32(19), 3047–3048. doi: /10.1093/bioinformatics/btw354</li>"
252-
].join(' ').trim()
247+
"<li>Andrews S, (2010) FastQC, URL: https://www.bioinformatics.babraham.ac.uk/projects/fastqc/.</li>",
248+
"<li>Ewels, P., Magnusson, M., Lundin, S., & Käller, M. (2016). MultiQC: summarize analysis results for multiple tools and samples in a single report. Bioinformatics, 32(19), 3047–3048. doi: /10.1093/bioinformatics/btw354</li>",
249+
"<li>Wingett SW, Andrews S. FastQ Screen: A tool for multi-genome mapping and quality control. F1000Res. 2018 Aug 24 [revised 2018 Jan 1];7:1338. doi: 10.12688/f1000research.15931.2. eCollection</li>",
250+
params.sample_size > 0 ? "<li>Li, H. SeqTk. Available online: https://github.com/lh3/seqtk (accessed on 6 May 2021)</li>" : "",
251+
"<li>Telatin, A.; Fariselli, P.; Birolo, G. SeqFu: A Suite of Utilities for the Robust and Reproducible Manipulation of Sequence Files. Bioengineering 2021, 8, 59. https://doi.org/10.3390/bioengineering8050059</li>"
252+
].join(' ').trim()
253253

254254
return reference_text
255255
}
@@ -275,13 +275,8 @@ def methodsDescriptionText(mqc_methods_yaml) {
275275
meta["nodoi_text"] = meta.manifest_map.doi ? "" : "<li>If available, make sure to update the text to include the Zenodo DOI of version of the pipeline used. </li>"
276276

277277
// Tool references
278-
meta["tool_citations"] = ""
279-
meta["tool_bibliography"] = ""
280-
281-
// TODO nf-core: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
282-
// meta["tool_citations"] = toolCitationText().replaceAll(", \\.", ".").replaceAll("\\. \\.", ".").replaceAll(", \\.", ".")
283-
// meta["tool_bibliography"] = toolBibliographyText()
284-
278+
meta["tool_citations"] = toolCitationText().replaceAll(", \\.", ".").replaceAll("\\. \\.", ".").replaceAll(", \\.", ".")
279+
meta["tool_bibliography"] = toolBibliographyText()
285280

286281
def methods_text = mqc_methods_yaml.text
287282

0 commit comments

Comments
 (0)