Skip to content

Conversation

@GustavoYnada
Copy link

Readme updated with the pipelines descriptions

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/seqinspector branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Readme updated with the pipelines descriptions
@github-actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @GustavoYnada,

It looks like this pull-request is has been made against the GustavoYnada/seqinspector master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the GustavoYnada/seqinspector dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@FranBonath FranBonath changed the base branch from master to dev March 26, 2025 08:07
@FranBonath
Copy link
Member

I changed the base to dev. We don't usually open PRs to master ;)

@FranBonath FranBonath mentioned this pull request Mar 26, 2025
11 tasks
@matrulda matrulda self-requested a review March 26, 2025 12:18
Copy link
Contributor

@matrulda matrulda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! I left some comments for you.

In addition to the comments, make sure to address the PR checklist


<h1>
<picture>
<source media="(prefers-color-scheme: dark)" srcset="docs/images/seqinspector_poster_2024_v4.png">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be included in the PR? Anyhow, I think it would be better to use a picture of the tube map instead: #85


**nf-core/seqinspector** is a bioinformatics pipeline that ...
**nf-core/seqinspector** -
<p align="justify"> <br>A basic QC pipeline for sequencing core facilities providing high quality data from a range of different sequencing instruments to their users is in the interest of every sequencing facility. In order to monitor their sequencing quality, performing standardized, yet flexible quality controls for every sequencing project and sample that passes through their facilities is crucial to ensure consistent quality and dependable results.</br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not really comply with the TODO that the description should be very short:

<!-- TODO nf-core:
   Complete this sentence with a 2-3 sentence summary of what types of data the pipeline ingests, a brief overview of the
   major pipeline sections and the types of output it produces. You're giving an overview to someone new
   to nf-core here, in 15-20 seconds. For an example, see https://github.com/nf-core/rnaseq/blob/master/README.md#introduction
-->

Could you slim this down?

Also remove the TODO section below this when it is done

@matrulda
Copy link
Contributor

I will close this PR in favor of #104

@matrulda matrulda closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants