-
Notifications
You must be signed in to change notification settings - Fork 38
DO NOT MERGE: FIRST RELEASE CORE - COMMUNITY PUBLIC REVIEW #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 250 commits
Commits
Show all changes
636 commits
Select commit
Hold shift + click to select a range
ebe23fb
Merge pull request #133 from nf-core/nf-core-template-merge-3.4.1
FranBonath aa0ee42
Merge branch 'dev' into bwa_index
maxulysse 1e472c8
Merge branch 'dev' into picard_tools_dev
maxulysse b119692
fix snapshots
maxulysse d45e427
fix snapshots
maxulysse 3352f23
Merge branch 'dev' into multiqc-index
pontushojer 17bbc74
.bai files in the same folder as bam files
agrima2010 ce94600
update snapshots
maxulysse b9c09ed
update modules
maxulysse 8e76c46
update snapshots once again
maxulysse f38e893
patch fastqscreen/fastqscreen
maxulysse de6821f
Merge pull request #128 from agrima2010/picard_tools_dev
maxulysse 37706c4
Merge branch 'dev' into bwa_index
maxulysse c28635a
Update CHANGELOG.md
maxulysse 205c2e3
solve merge conflicts
maxulysse f281848
removed hasta config and corrected nextflow_schema.json
agrima2010 6edf19f
nextflow_schema.json
agrima2010 aff9444
nextflow.config
agrima2010 d9373dd
removed channel output of BAM from seqinspector.nf
agrima2010 2bc95ba
bwa_index added to nextflow.config
agrima2010 1fc87a8
Update nextflow_schema.json
agrima2010 71287cd
Merge pull request #132 from agrima2010/bwa_index
agrima2010 f3b0108
Merge branch 'dev' into nf-core-template-merge-3.5.1
maxulysse 3a77ea6
fix multiqc modules install
maxulysse a45f606
Merge pull request #144 from nf-core/nf-core-template-merge-3.5.1
maxulysse de0cdb8
Merge branch 'dev' into run-dirs
matrulda b85608c
Update rundirparser test and add nextflow config for it
matrulda 6e961e8
Fix #94. Remove outdated TODOs
KarNair a3ad873
Add #94 to Changelog
KarNair ab40404
Add #94 to Changelog
KarNair abf53dc
Update README.md
FranBonath 31e3a83
Merge branch 'dev' into dev_docs
FranBonath fbba2d4
Merge pull request #145 from KarNair/validate-test-data
KarNair 8f71810
Merge pull request #111 from Patricie34/dev_docs
FranBonath 8c09da2
add tubemap and logo to intro page
FranBonath 2a460f4
fix merge conflicts
FranBonath 317cfd4
update tubemap and some updates to README
FranBonath 7996d9e
update tubmap again
FranBonath 930f0f2
add SeqFu Stats to README.md
FranBonath 2aad60b
Install picard_collecthsmetrics.
bbd7eed
Install picard_createsequencedictionary.
4acac74
Add test samplesheet and test config.
38b2fae
Change modules.json to include installed modules.
71f1fe7
Set up input parameters.
62cc3ce
Add picard_collecthsmetrics to workflow.
df6ebc1
Make SAMTOOLS_INDEX required if bwamem2_mem is run.
72291c3
Rundirparser: Add tar support, remove dummy script, update format of …
matrulda f422cd8
Remove skip condition for samtools_index when calling picard_collectm…
f91167b
Have tools list in README in Table
FranBonath 0894a2b
lint errors
ramprasadn 4c4214b
add darkmode options in README, add darkmode tubemap
FranBonath 06e66ac
lint warnings
ramprasadn 226c89f
Add qc_bam subworkflow to run picard_collecthsmetrics.
069ee40
Add subworkflow qc_bam.
98ab4a3
Add subworkflow QC_BAM.
2083cfc
Add logic to skip collecthsmetrics by default through addin "run_pica…
66f0c38
Modified seqinspector.nf and added subworkflow
agrima2010 8a68c93
Add TMP_DIR argument to picard_collecthsmetrics.
3693ca5
update README and usage.md
FranBonath 48eec4e
Create subworkflow directory. Change channels created from params to …
75b2f5e
Add curly braket.
f014036
Add second sample to samplesheet.
bc3320f
Fix ch_ref_dict.
5381e4e
Remove outdated qc_bam.nf.
7473297
Update README.md
FranBonath b478b36
Update README.md
FranBonath 95582a0
[automated] Fix code linting
nf-core-bot 34baa10
Change if order in qc_bam.
4637abb
Merge pull request #148 from FranBonath/dev
FranBonath 9f1305e
update output.md
FranBonath 0743b58
Added subworkflow prepare_genome
agrima2010 edf9076
Move creation of ch_hsmetrics_in to qc_bam.
1326cec
Merge branch 'nf-core:dev' into output_changes
FranBonath bf11922
Add qc_bam test!
f8158fd
Remove test config and samplesheet.
73efbf7
Minor changes
agrima2010 0e3f63f
Snapshots
agrima2010 f876645
Add defaults for collecthsmetrics in modules.config.
15142b8
Fix so output files are only accessed if QC_BAM is run.
49e1095
ss
agrima2010 452ca7b
fix precommit
agrima2010 aed9052
Merge branch 'dev' into collethsmetrics
eliottBo 14f626c
Add rundirparser as skip option
matrulda c7444af
Adapt tests for rundirparser (only NovaSeq6000 test data have the req…
matrulda 0009fb6
Add information about run_picard_collecthsmetrics flag to usage.md
eliottBo 3e62620
Changed parameter bwa_index to bwamem2 and changed channel names
agrima2010 b4ef71c
Update README.md
dfbc994
Update CITATIONS.md.
40cd40a
Add PR link to CHANGELOG.md
eliottBo c4eca8c
Merge branch 'collethsmetrics' of https://github.com/eliottBo/seqinsp…
eliottBo f413842
Update output.md.
14ed134
WIP: Updating module test for rundirparser
matrulda cc77efa
Remove cg_test profile.
d0a960a
Add output file description for CollectHsMetrics in output.md
eliottBo ae00279
update tools table in README
FranBonath 2583e5e
Fix title in Picard CollectHSmetrics in output.md
eliottBo c35a1d9
Add File description for collecthsmetrics in output.md
eliottBo 35626f4
Merge branch 'collethsmetrics' of https://github.com/eliottBo/seqinsp…
eliottBo ddafe8b
Merge branch 'dev' into changes_usage.md
KarNair ee4afdb
Merge pull request #150 from ramprasadn/pipeline-lint
ramprasadn 0b3af15
Update README.md
FranBonath 76038b5
[automated] Fix code linting
nf-core-bot 985ddcb
Added params in root main.nf and snapshots
agrima2010 646ddef
Merge branch 'dev' into subworkflows
agrima2010 4376756
Merge pull request #153 from FranBonath/changes_usage.md
KarNair 505fa03
Move picard_collectmultiplemetrics to QC_BAM.
e40b3f0
Merge branch 'dev' into collethsmetrics
beatrizsavinhas bfa3cd3
Update README.md
beatrizsavinhas 509087f
Fix output channels.
92ad8a7
Updated CHANGE LOG
agrima2010 3de0c5f
Merge branch 'dev' into change-qc-bam
beatrizsavinhas 061ec28
Merge branch 'subworkflows' of https://github.com/agrima2010/seqinspe…
agrima2010 712495d
Merge pull request #151 from agrima2010/subworkflows
agrima2010 5746497
Fix linting issues.
e8e43bd
Update CHANGELOG.md
beatrizsavinhas e74488f
Merge branch 'dev' into collecthsmetrics
beatrizsavinhas 19768f7
Update seqinspector.nf
42a8ff5
Fix linting erros.
bc0edf9
Fix test snap generation.
5444402
Fix linting issues.
a4f2666
Run prettier and remove trailing whitespace.
b0bb6ae
Fix end of files.
8370238
Remove cg_test config.
ab4ff6d
Trim trailing whitespace.
10f30df
Remove picard_collecthsmetrics from skip_tools as it is not run by de…
3b45465
Update usage.md.
566e4c9
Seqtk add relative sample sets and warning
nkongenelly 8ad085f
Fixing tests
nkongenelly 2e1b664
Fixed test error
nkongenelly 5d3309b
[automated] Fix code linting
nf-core-bot 432816b
Harshil alignment
eliottBo d724965
Update ro-crate
eliottBo 8838130
Format seqinspector.nf.
0af25a1
Restore output.md.
739e7d8
Add input parameter notes for QC_BAM.
b5ef24a
Fix input notes.
ad3b333
Update input parameter notes.
8e08426
Move PICARD_CREATESEQUENCEDICTIONARY to PREPARE_GENOME. Adjust QC_BAM…
5ec2712
Initialise ch_ref_dict in PREPARE_GENOME.
0023329
Harshil alignment
eliottBo 845a749
Merge branch 'dev' into multiqc-index
pontushojer 52cce2f
Update snapshot for QC_BAM.
55f2d6f
Update CHANGELOG.md
beatrizsavinhas 6ee64f3
Merge branch 'collecthsmetrics' into change-qc-bam
79356af
Correct QC_BAM main.nf.
6a1b397
Remove PICARD_COLLECTMULTIPLEMETRICS from seqinspector.nf.
fa53330
Fix linting issues.
2238747
Add checks for empty params bait_intervals and target_intervals.
4d02baf
Fix QC_BAM input parameters.
028d095
Update QC_BAM test.
4ddf032
Update usage.md
beatrizsavinhas 399e1ce
Merge branch 'collecthsmetrics' into change-qc-bam
030eb2e
Edit CHANGELOG.md
03a9731
Run prettier.
f7fadab
Merge branch 'collecthsmetrics' into change-qc-bam
d71d935
Rename ch_reference_fai.
520ccdc
Update PREPARE_GENOME input parameters description
9a44235
Merge pull request #159 from eliottBo/collecthsmetrics
beatrizsavinhas 40a7053
Merge branch 'nf-core:dev' into change-qc-bam
beatrizsavinhas 95ac7b5
Fix prepare_genome/main.nf
5a1196c
Add tests
7709979
Update test
8c6edff
Merge branch 'dev' into test-prepare-genome
beatrizsavinhas f57ef72
Update prepare_genome/main.nf
dc9690e
Add publishDir for PICARD_CREATESEQUENCEDICTIONARY
63df743
Refactor tests
c26104c
Fix end of file main.nf.test
e55caaa
Update CHANGELOG.md
83e319a
Update CHANGELOG.md
446651d
Revert redundant changes in modules.config
8d3a773
Update some snapshots
a9e3b30
More snapshot updates
815176e
Update remaining snapshot
8ea7b63
Re-add changes to modules.config
60e8666
Small changes in comments in main.nf.test
d5f69b8
Small changes in comments in main.nf.test
d64f815
Add nextflow.config to tests
4a5d3a1
Update tests and snapshot
4e43aec
Add EOL to nextflow.config
fb4376d
Update QC_BAM input description
5614398
Update PREPARE_GENOME test configs
1f7cae8
Update snapshots
9d9a2f9
Add test nextflow.config
783f565
Update test configs to remove hardcoded pipelines_testdata_base_path …
8ac6732
Remove redundant / in test-data paths
2c408f9
Merge pull request #158 from eliottBo/change-qc-bam
beatrizsavinhas 0c33826
Merge branch 'nf-core:dev' into test-prepare-genome
beatrizsavinhas 8bf9588
run fastqscreen with subsampled data if available
pontushojer 2345202
update changelog
pontushojer 324851e
Fix bug preventing picard_multiple_metrics files from being passed to…
67db2a9
Update CHANGELOG.md
6f71488
Update CHANGELOG.md
beatrizsavinhas 743ae2d
Merge pull request #163 from pontushojer/sample_fastqscreen
pontushojer 6534925
Merge branch 'dev' into test-prepare-genome
maxulysse 204cc02
fix snapshot
maxulysse 82a49d9
Merge pull request #162 from beatrizsavinhas/test-prepare-genome
beatrizsavinhas e0ae79d
Merge pull request #135 from pontushojer/multiqc-index
pontushojer f103e6b
Merge branch 'dev' into output_changes
maxulysse d16f194
Merge pull request #152 from FranBonath/output_changes
maxulysse 94b8bfd
Merge branch 'dev' into sample-naming
maxulysse 8318295
re-generate snapshots
maxulysse 3ba97e7
Merge branch 'dev' into seqtk_sample_size_warning
maxulysse 64e0a44
Merge pull request #121 from pontushojer/sample-naming
maxulysse 412978e
re-generate snapshots
maxulysse 0cbe100
Update workflows/seqinspector.nf
maxulysse dba2d8f
Merge branch 'dev' into seqtk_sample_size_warning
maxulysse 9f98c4b
use log.warn, and update tests
maxulysse afe2f84
Merge pull request #156 from nkongenelly/seqtk_sample_size_warning
maxulysse 61f172b
Merge branch 'dev' into run-dirs
maxulysse c1576e2
update snapshots
maxulysse d4c5306
update module
maxulysse 54609e9
code polish + topics
maxulysse ea4b20c
code polish
maxulysse 16db84c
fix tests
maxulysse daf18b0
no need for view()
maxulysse 70fdcf2
simplify config
maxulysse 8766778
dir_meta -> meta
maxulysse 4a5024c
Delete modules/local/rundirparser/meta.yml
maxulysse ff89c38
Update tests/NovaSeq6000.main.nf.test.config
maxulysse dcd7c8a
sort modules import
maxulysse f54f4c7
sort import
maxulysse 5d224a4
Trigger Build
maxulysse 5f04718
update snapshots
maxulysse 5c68a10
Merge pull request #106 from kedhammar/run-dirs
maxulysse e78578d
rename test files and delete config
maxulysse b3e6fed
need the params in the tests for now
maxulysse dbe8114
early failure for test for smaller diff
maxulysse e09b166
simplify tests
maxulysse ba22c67
polish local subworkflows and tests
maxulysse 4201300
bam are unstable
maxulysse 8a49714
fix prepare_genome tests and snapshots
maxulysse b39fff7
code polish
maxulysse 7d4b433
remove file from snapshot
maxulysse 44889d2
fix qc_bam subworkflow tests
maxulysse eaf4328
update and improve CHANGELOG
maxulysse bb585d0
add missing entries
maxulysse 9371567
code polish
maxulysse 052b7ea
fix polish
maxulysse a4ba47c
Merge pull request #164 from nf-core/tests_cleanup
maxulysse cfd4a8d
Skip RUNDIRPARSER if no rundir information is available
matrulda 6e56eab
Add 167 to changelog
matrulda 960728a
Add test for no rundir information scenario
matrulda e535dc1
Add note about RUNDIRPARSER being skipped when not using rundir
matrulda 749aee2
pre-commit fix
matrulda d080687
Write warning if rundir is missing for a sample
matrulda c4052c6
Merge pull request #167 from matrulda/issue-166_document_rundir_parser
maxulysse 9da961c
Address review comments (#168)
maxulysse 9df5cfc
prepare release 1.0.0 (#169)
maxulysse 204b44d
rescure size from the pipeline tests (#171)
maxulysse 2a59538
fix conda env for rundirparser (#172)
maxulysse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,3 +7,5 @@ testing/ | |
| testing* | ||
| *.pyc | ||
| null/ | ||
| .nf-test | ||
| .nf-test.log | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| name,dir,basename,aligner | ||
| Ecoli,s3://ngi-igenomes/igenomes/Escherichia_coli_K_12_MG1655/NCBI/2001-10-15/Sequence/Bowtie2Index/,genome,bowtie2 | ||
| PhiX,s3://ngi-igenomes/igenomes/PhiX/Illumina/RTA/Sequence/Bowtie2Index/,genome,bowtie2 | ||
| Scerevisiae,s3://ngi-igenomes/igenomes/Saccharomyces_cerevisiae/NCBI/build3.1/Sequence/Bowtie2Index/,genome,bowtie2 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.