-
Notifications
You must be signed in to change notification settings - Fork 38
Address review comments #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
db94f15
split paragraph and remove that duplication
maxulysse 38a8ee1
fix typo
maxulysse 3a0683b
Add author and licence
maxulysse 6297cca
Add contributor list
maxulysse 6cc2e1c
Apply suggestions from code review
maxulysse 2b42571
update author list
maxulysse e029023
Update nextflow.config
maxulysse ad4fd42
Update nextflow.config
maxulysse 62bc010
Apply suggestion from @maxulysse
maxulysse a349984
Apply suggestion from @maxulysse
maxulysse 8045ee5
nextflow lint
maxulysse c85ffaf
nextflow lint
maxulysse ea1cf3b
nextflow lint
maxulysse 74c9e0b
README
maxulysse 0a5fe3b
sort
maxulysse c035be0
fix size
maxulysse e43fe51
function is actually usefull
maxulysse 9afc959
remove tests coming from modules
maxulysse 2a76a9c
precommit
maxulysse bc8f034
nextflow lint
maxulysse 862303c
CHANGELOG
maxulysse 6f74585
address comment
maxulysse eb942c9
rocrate
maxulysse f72d0ed
add bowtie2 and sort
maxulysse 65ce781
citations
maxulysse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -252,12 +252,150 @@ manifest { | |
| name = 'nf-core/seqinspector' | ||
| contributors = [ | ||
| [ | ||
| name: 'National Genomics Infrastructure', | ||
| affiliation: '', | ||
| email: '', | ||
| github: 'https://github.com/NationalGenomicsInfrastructure/', | ||
| contribution: ['author'], // List of contribution types ('author', 'maintainer' or 'contributor') | ||
| orcid: '' | ||
| name: 'Adrien Coulier', | ||
| affiliation: 'Pixelgen Technologies', | ||
| github: 'Aratz', | ||
| contribution: ['author'] | ||
| ], | ||
| [ | ||
| name: 'Alfred Kedhammar', | ||
| affiliation: 'Clinical Genomics', | ||
| github: 'kedhammar', | ||
|
Comment on lines
+261
to
+263
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kedhammar any more info, like ORCID? |
||
| contribution: ['author'] | ||
| ], | ||
| [ | ||
| name: 'Agrima Bhatt', | ||
| affiliation: 'National Genomics Infrastructure', | ||
| github: 'agrima2010', | ||
maxulysse marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| orcid: '0009-0004-5536-7210' | ||
| contribution: ['author'] | ||
| ], | ||
| [ | ||
| name: 'Maxime U Garcia', | ||
| affiliation: 'National Genomics Infrastructure', | ||
| github: 'maxulysse', | ||
| contribution: ['maintainer'], | ||
| orcid: '0000-0003-2827-9261' | ||
| ], | ||
| [ | ||
| name: 'Natalia Garcia Garcia', | ||
| github: 'nggvs', | ||
|
Comment on lines
+281
to
+282
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @nggvs any more info, like affiliation or ORCID? |
||
| contribution: ['contributor'] | ||
| ], | ||
| [ | ||
| name: 'Franziska Bonath', | ||
| affiliation: 'National Genomics Infrastructure', | ||
| github: 'FranBonath', | ||
maxulysse marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| contribution: ['author'] | ||
maxulysse marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ], | ||
| [ | ||
| name: 'Pontus Höjer', | ||
| affiliation: 'National Genomics Infrastructure', | ||
| github: 'pontushojer', | ||
| contribution: ['contributor'], | ||
| orcid: '0000-0001-8010-4755' | ||
| ], | ||
| [ | ||
| name: 'Edmund Miller', | ||
| affiliation: 'Seqera', | ||
| github: 'edmundmiller', | ||
| contribution: ['contributor'] | ||
| ], | ||
| [ | ||
| name: 'Mahesh Binzer-Panchal', | ||
| affiliation: 'National Bioinformatics Infrastructure Sweden', | ||
| github: 'mahesh-panchal', | ||
| contribution: ['contributor'] | ||
| ], | ||
| [ | ||
| name: 'Ramprasad Neethiraj', | ||
| affiliation: 'Clinical Genomics', | ||
| github: 'ramprasadn', | ||
| contribution: ['author'] | ||
| ], | ||
| [ | ||
| name: 'Matilda Åslin', | ||
| affiliation: 'National Genomics Infrastructure', | ||
| github: 'matrulda', | ||
| contribution: ['author'] | ||
| ], | ||
| [ | ||
| name: 'Patricie Skaláková', | ||
| affiliation: 'Masaryk University', | ||
| github: 'Patricie34', | ||
| contribution: ['contributor'] | ||
| ], | ||
| [ | ||
| name: 'Eliott Bosshard', | ||
| affiliation: 'Clinical Genomics', | ||
| github: 'EliottBo', | ||
| contribution: ['contributor'] | ||
| ], | ||
| [ | ||
| name: 'Karthik Nair', | ||
| affiliation: 'National Genomics Infrastructure', | ||
| github: 'KarNair', | ||
| contribution: ['contributor'] | ||
| ], | ||
| [ | ||
| name: 'Matthias Zepper', | ||
| affiliation: 'National Genomics Infrastructure', | ||
| github: 'MatthiasZepper', | ||
| contribution: ['author'] | ||
| ], | ||
| [ | ||
| name: 'Nelly Nyawira Nkonge', | ||
| affiliation: 'National Genomics Infrastructure', | ||
| github: 'nkongenelly', | ||
| contribution: ['contributor'] | ||
| ], | ||
| [ | ||
| name: 'Beatriz Vinhas', | ||
| affiliation: 'Clinical Genomics', | ||
| github: 'beatrizsavinhas', | ||
| contribution: ['contributor'] | ||
| ], | ||
| [ | ||
| name: 'Júlia Mir Pedrol', | ||
| affiliation: 'Center For Genomics Regulation', | ||
| github: 'mirpedrol', | ||
| contribution: ['contributor'] | ||
| ], | ||
| [ | ||
| name: 'Cristina Tuñí i Domínguez', | ||
| affiliation: 'Flowmics', | ||
| github: 'ctuni', | ||
| contribution: ['contributor'] | ||
| ], | ||
| [ | ||
| name: 'Johannes Alneberg', | ||
| affiliation: 'National Genomics Infrastructure', | ||
| github: 'alneberg', | ||
| contribution: ['contributor'] | ||
| ], | ||
| [ | ||
| name: 'Annick Renevey', | ||
| affiliation: 'Clinical Genomics', | ||
| github: 'rannick', | ||
| contribution: ['contributor'] | ||
| ], | ||
| [ | ||
| name: 'Adam Talbot', | ||
| affiliation: 'Seqera', | ||
| github: 'adamrtalbot', | ||
| contribution: ['contributor'] | ||
| ], | ||
| [ | ||
| name: 'Jonas Kjellin', | ||
| affiliation: 'National Genomics Infrastructure', | ||
| github: 'kjellinjonas', | ||
| contribution: ['contributor'] | ||
| ], | ||
| [ | ||
| name: 'Tori Griffin', | ||
| affiliation: 'National Genomics Infrastructure', | ||
| github: 'torigiffin', | ||
| contribution: ['contributor'] | ||
| ], | ||
| ] | ||
| homePage = 'https://github.com/nf-core/seqinspector' | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aratz any more info, like ORCID?