Skip to content

rescue size from the pipeline tests#171

Merged
maxulysse merged 1 commit intodevfrom
restore_size
Feb 11, 2026
Merged

rescue size from the pipeline tests#171
maxulysse merged 1 commit intodevfrom
restore_size

Conversation

@maxulysse
Copy link
Member

@maxulysse maxulysse commented Feb 11, 2026

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/seqinspector branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Feb 11, 2026 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 77ead00

+| ✅ 192 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   3 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add bibliography of tools and data used in your pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.2
  • Run at 2026-02-11 10:17:27

mashehu
mashehu approved these changes Feb 11, 2026
View reviewed changes
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want them back, I thought we were going away from this kind of test

@maxulysse
Copy link
Member Author

maxulysse commented Feb 11, 2026

Why do you want them back, I thought we were going away from this kind of test

I think we want them back as it was only an issue for some edge versions

@maxulysse maxulysse merged commit 204b44d into dev Feb 11, 2026
21 checks passed
@maxulysse maxulysse deleted the restore_size branch February 11, 2026 11:32
@maxulysse maxulysse changed the title rescure size from the pipeline tests rescue size from the pipeline tests Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mashehu mashehu mashehu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxulysse @mashehu