Skip to content

FIX: tag collision warning#183

Open
maxulysse wants to merge 7 commits intodevfrom
fix_tag_collision
Open

FIX: tag collision warning#183
maxulysse wants to merge 7 commits intodevfrom
fix_tag_collision

Conversation

@maxulysse
Copy link
Member

@maxulysse maxulysse commented Feb 25, 2026

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/seqinspector branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Feb 25, 2026 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 0d66c2d

+| ✅ 196 tests passed       |+
#| ❔   8 tests were ignored |#
Details

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.2
  • Run at 2026-02-27 10:45:34

@maxulysse maxulysse changed the title Fix tag collision Remove tag collision warning Feb 26, 2026
@maxulysse maxulysse changed the title Remove tag collision warning FIX: tag collision warning Feb 27, 2026
FranBonath
FranBonath reviewed Feb 27, 2026
View reviewed changes
subworkflows/local/utils_nfcore_seqinspector_pipeline/main.nf
.map { _tag_lowercase, tags ->
if (tags.size() == 1) {
if (tags.size() != 1) {
log.warn("Tag name collision: " + tags)
Copy link
Member

@FranBonath FranBonath Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we make this warning more clear? For example

Suggested change
log.warn("Tag name collision: " + tags)
log.warn("Tag name collision, these tags will be handled as one tag: " + tags)

Copy link
Member Author

@maxulysse maxulysse Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's more, each of these tags will be a separate one

Copy link
Collaborator

@Aratz Aratz Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Tag name collision, on macs, these tags will be handled as one tag: ?

Copy link
Member Author

@maxulysse maxulysse Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah something like that is better

Aratz
Aratz reviewed Feb 27, 2026
View reviewed changes
@maxulysse @Aratz
Update docs/usage.md
0d66c2d 
Co-authored-by: Adrien Coulier <adrien.coulier@medsci.uu.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FranBonath FranBonath FranBonath left review comments

@Aratz Aratz Aratz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxulysse @Aratz @FranBonath