Move gather_registries function to ContainerFetcher subclasses (#3634 follow-up)#3696
Conversation
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1ddc474 to
957190e
Compare
|
I've looked into this a bit more and since it seems that Of course, this is true for the other PRs too (this PR only changes where the |
|
Docs updated in nf-core/website#3463. Note that I have not addressed the issue in the comment above |
This is a follow up PR on the large
nf-core pipelines downloadrefactor PR #3634 and the test PR #3712, and should be merged AFTER it.This PR moves the
gather_registriesfunction fromnf-core/pipelines/download/download.pytoContainerFetcherand subclasses.gather_registriesfunction inSingularityFetchermirrors the previous one.DockerFetcherclass only uses thedocker.registryandpodman.registryin the config and the Seqera Docker container registry (community.wave.seqera.io/library).A diff with the
refactor-download-testsbase branch can be found in the dummy PR ErikDanielsson#1PR checklist
CHANGELOG.mdis updateddocsis updated