Skip to content

Conversation

@nvnieuwk
Copy link
Contributor

@nvnieuwk nvnieuwk commented Sep 26, 2025

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

- "{{ component }} --version":
type: string
description: The version of the tool

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to add a new section topics

@nvnieuwk nvnieuwk marked this pull request as ready for review October 14, 2025 14:46
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 86.58537% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.35%. Comparing base (24d2916) to head (5e39aa4).
⚠️ Report is 35 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/components/nfcore_component.py 81.08% 7 Missing ⚠️
nf_core/modules/lint/main_nf.py 89.47% 4 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add type hints to all the methods you added (not needed for tests)

@github-project-automation github-project-automation bot moved this from To do to In progress in Hackathon Barcelona October 2025 Oct 29, 2025
@nvnieuwk nvnieuwk merged commit da4cb3f into nf-core:dev Oct 29, 2025
116 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Hackathon Barcelona October 2025 Oct 29, 2025
@nvnieuwk nvnieuwk deleted the feat/topics branch October 29, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants