Skip to content

Conversation

@mashehu
Copy link
Contributor

@mashehu mashehu commented Oct 28, 2025

No description provided.

@mashehu mashehu requested a review from mirpedrol October 28, 2025 13:43
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add a short sentece about keeping the PRs open in the body of the PR pr_body_text, for example:

Note: Since version 3.5.0 of tools, previous template update PRs are kept open in your pipeline repository. You may choose to do the updates one version at a time or work on the latest PR and get all changes together. Make sure to check if you have other open sync PRs and 1. close them if you will work on the latest one, or 2. work on them before tackling the more recent ones.

Open to a better wording 😄

log.debug(f"GitHub API PR worked, return code {r.status_code}")
log.info(f"GitHub PR created: {self.gh_pr_returned_data['html_url']}")

def close_open_template_merge_prs(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't remove this functions, maybe we want to reimplement this in the future? But we could deprecate them for now, maybe add a TODO comment or something similar?

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.31%. Comparing base (24d2916) to head (8d07eec).

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mirpedrol mirpedrol added this to the 3.5.0 milestone Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants