Strelka vep cnaqc patch#48
Merged
valerianilucrezia merged 13 commits intonf-core:devfrom Dec 15, 2025
Merged
Conversation
Updating dev from nf-core repo
nicola-calonaci
requested changes
Dec 10, 2025
Collaborator
nicola-calonaci
left a comment
nicola-calonaci
left a comment
There was a problem hiding this comment.
Thanks for the feedback! Please see specific comments regarding the genome parameter.
Changing genome param to global genome value
Changing genome param to global genome value
Changing genome param to global genome value
RaqManzano
commented
Dec 12, 2025
Contributor
Author
RaqManzano
left a comment
RaqManzano
left a comment
There was a problem hiding this comment.
I removed the param cnaqc_genome in favour of just param genome as requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of updates
vcf2cnaqcsample names were showing asTUMORandNORMAL(default in strelka vcf). Now it gets the sample names from metadata.cnaqc_plot_cn(not present in Rscript template) and addedcnaqc_genometo support other genome versions.JOIN_CNAQC