buses/uart: Use 'lockf()' for serial locking#637
Open
thg2k wants to merge 1 commit intonfc-tools:masterfrom
Open
buses/uart: Use 'lockf()' for serial locking#637thg2k wants to merge 1 commit intonfc-tools:masterfrom
thg2k wants to merge 1 commit intonfc-tools:masterfrom
Conversation
Using this standard Linux mechanism to lock serial ports has the advantage that if the process is killed the lock is automatically released. Before a lock was simulated using the custom termios 'c_iflag' value 0x80000000, which has the disadvantage, other than being non-standard, that if the process is killed before closing the serial port, it would appear as locked and require manual cleanup of the flag. Signed-off-by: Giovanni Giacobbi <giovanni@giacobbi.net>
smortex
approved these changes
Aug 18, 2021
Contributor
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
We seem to have a compatible lockf(3) on FreeBSD:
STANDARDS
The lockf() function conforms to X/Open Portability Guide Issue 4,
Version 2 (“XPG4.2”).
Member
|
Does it work under Windows? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this standard Linux mechanism to lock serial ports has the advantage that if the process is killed the lock is automatically released.
Before a lock was simulated using the custom termios 'c_iflag' value 0x80000000, which has the disadvantage, other than being non-standard, that if the process is killed before closing the serial port, it would appear as locked and require manual cleanup of the flag.