Skip to content

Explicit uint32_t cast for crypto1 state calculations #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sublime-elephant wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Explicit uint32_t cast for crypto1 state calculations #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48cceb6
Explicit uint32_t cast for crypto1 state calculations
sublime-elephant Mar 12, 2026
2affa0f
Merge pull request #1 from sublime-elephant/sublime-elephant-patch-1
sublime-elephant Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/crypto1.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ uint8_t crypto1_byte(struct Crypto1State *s, uint8_t in, int is_encrypted)
uint8_t i, ret = 0;

for (i = 0; i < 8; ++i)
ret |= crypto1_bit(s, BIT(in, i), is_encrypted) << i;
ret |= ((uint32_t)crypto1_bit(s, BIT(in, i), is_encrypted)) << i;

return ret;
}
Expand All @@ -76,7 +76,7 @@ uint32_t crypto1_word(struct Crypto1State *s, uint32_t in, int is_encrypted)
uint32_t i, ret = 0;

for (i = 0; i < 32; ++i)
ret |= crypto1_bit(s, BEBIT(in, i), is_encrypted) << (i ^ 24);
ret |= ((uint32_t)crypto1_bit(s, BEBIT(in, i), is_encrypted)) << (i ^ 24);

return ret;
}
Expand Down