Fix mappings IRI separator to enable round-tripping#350
Merged
Conversation
Change all 5 " ".join() calls for mapping IRIs to "\n".join() to match the read side, consistent with how parent_iris and influenced_by_iris already work.
github-project-automation
bot
moved this from In progress
to Completed
in Voc4Cat cross-repo view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rdf_mappings_to_v1() was joining multiple IRIs with spaces, but the reader (expand_iri_list) splits on newlines. This caused silent data loss on round-trip: the entire space-joined string was treated as a single malformed IRI.
This PR changes all 5 " ".join() calls to "\n".join() to match the read side, consistent with how parent_iris and influenced_by_iris already work.
Closes #349