fix: don't wrap first part of command in quotes #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems as though some Windows systems don't allow the first part of the command to be wrapped in quotes. We couldn't detect this issue on CI, but this was reported by a user. Fixes #7
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 27 32 +5
=========================================
+ Hits 27 32 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This swaps the internal implementation to use the new shell.cmd() API. This avoids the need for wrapping with double quotes which should also mean better compatibility on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems as though some Windows systems don't allow the first part of the command to be wrapped in quotes. We couldn't detect this issue on CI, but this was reported by a user.
Fixes #7