Skip to content

Conversation

@NaridaL
Copy link
Collaborator

@NaridaL NaridaL commented Mar 15, 2025

Fixes #

Proposed changes

Code quality

  • I made some tests for my changes
  • I added my name in the
    contributors
    field of the package.json file. Beware to use the same format than for the author field
    for the entries so that you'll get a mention in the README.md with a link to your website.

License

To get your contribution merged, you must check the following.

  • I read the project license in the LICENSE file
  • I agree with publishing under this project license

Join

  • I wish to join the core team
  • I agree that with great powers comes responsibilities
  • I'm a nice person

My NPM username:

@armano2
Copy link
Contributor

armano2 commented Mar 15, 2025

env varibales are not really needed if we update/cleanup dependencies #88

@NaridaL
Copy link
Collaborator Author

NaridaL commented Mar 15, 2025

ok well it looks like metapak doesn't like my change, but without it I can't run the preversion sript on windows so not sure how to resolve this.

@nfroidure

@NaridaL
Copy link
Collaborator Author

NaridaL commented Mar 15, 2025

env varibales are not really needed if we update/cleanup dependencies #88

That's a bit more than a cleanup no? Why replace jest?

@armano2
Copy link
Contributor

armano2 commented Mar 15, 2025

metapak hasn't been updated in a while, and it's regenerating all files every time when its run, thats also a reason why #81 is failing

@NaridaL NaridaL closed this Mar 15, 2025
@NaridaL NaridaL deleted the cross-env branch March 15, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants