Skip to content

Conversation

@armano2
Copy link
Contributor

@armano2 armano2 commented Mar 16, 2025

Proposed changes

  • reduce package size by not building test files during build

alternatively we could add .npmignore file and let test files to be built
https://github.com/nfroidure/svg-pathdata/blob/v6.0.3/.npmignore
https://packagephobia.com/[email protected]

Code quality

  • I made some tests for my changes

License

To get your contribution merged, you must check the following.

  • I read the project license in the LICENSE file
  • I agree with publishing under this project license

@NaridaL
Copy link
Collaborator

NaridaL commented Mar 16, 2025

npmignore seems like the way to go

@armano2 armano2 force-pushed the build/do-not-emit-test-files branch from 4241a79 to b733ee1 Compare March 16, 2025 22:24
@armano2
Copy link
Contributor Author

armano2 commented Mar 16, 2025

sadly .npmignore is not working with files form package json, i modified package.json instead,

you can verify it before publishing with npm pack

@armano2 armano2 closed this Jun 24, 2025
@armano2 armano2 deleted the build/do-not-emit-test-files branch June 24, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants