Add dictionary to configure delegations and async#129
Add dictionary to configure delegations and async#129animesh-javali wants to merge 1 commit intonfs-ganesha:centos-cifrom
Conversation
|
|
||
| if self.test_type == "pynfs": | ||
| delegations_v4 = " Delegations = true;" | ||
| delegations_export = " delegations = readwrite;" |
There was a problem hiding this comment.
Since we are changing the export readwrite to None, the gatecheck may fail..
Can you update the "tests/test_pynfs_cthon.py" file "Test 2" with additional param of ganesha_opts, so that gatecheck will continue to be green
tests/dev_space/test_fsal.py
Outdated
| cephfs_name=ceph_setup.cephfs_name | ||
| cephfs_name=ceph_setup.cephfs_name, | ||
| #ganesha_opts={ | ||
| #"delegations_v4": "true", |
There was a problem hiding this comment.
Can we remove this commented line?
| ceph_async = "true" | ||
|
|
||
| # ---- override only if ganesha_opts are passed ---- | ||
| if self.ganesha_opts and self.test_type == "pynfs": |
There was a problem hiding this comment.
Since we are updating ganesha_opts, we can remove self.test_type == "pynfs" this check
animesh-javali
force-pushed
the
centos-ci
branch
2 times, most recently
from
57a8a18 to
fe1d4c4
Compare
animesh-javali
force-pushed
the
centos-ci
branch
from
fe1d4c4 to
54e0b6d
Compare
By default, GaneshaManager generates a standard configuration with default values: Delegations = true, delegations = readwrite When ganesha_opts is provided, any of the following keys can override the defaults: delegations_v4: overrides the NFSv4 Delegations setting delegations_export: overrides the delegations setting in the EXPORT block ceph_async: overrides the async value in the CEPH block If ganesha_opts is empty or not provided, the existing configuration generation remains unchanged. This allows tests and setups to programmatically customize NFS-Ganesha configuration without manually editing the config file or creating separate templates. It keeps backward compatibility while supporting flexible overrides. Signed-off-by: Animesh Javali <Animesh.Javali@ibm.com>
animesh-javali
force-pushed
the
centos-ci
branch
from
54e0b6d to
fc71ff1
Compare
|
|
||
| assert rc == 0, f"Cthon CephFS tests failed" | ||
|
|
||
| ''' |
There was a problem hiding this comment.
Any reason why this is commented?
There was a problem hiding this comment.
ganesha_setup.setup() is failing here:
https://jenkins-nfs-ganesha.apps.ocp.cloud.ci.centos.org/me/my-views/view/all/job/test-delegation/25/console
There was a problem hiding this comment.
yes since full setup(installation of ceph) is already done, it fails to install it again.
2 participants
By default, GaneshaManager generates a standard configuration with default values:
Delegations = true, delegations = readwrite
When ganesha_opts is provided, any of the following keys can override the defaults:
delegations_v4: overrides the NFSv4 Delegations setting
delegations_export: overrides the delegations setting in the EXPORT block
ceph_async: overrides the async value in the CEPH block
If ganesha_opts is empty or not provided, the existing configuration generation remains unchanged.
This allows tests and setups to programmatically customize NFS-Ganesha configuration without manually editing the config file or creating separate templates.
It keeps backward compatibility while supporting
flexible overrides.