Skip to content

(fix): adjust gpfs kernel version comparison #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kalebskeithley merged 1 commit into from
Jan 23, 2026
Merged

(fix): adjust gpfs kernel version comparison #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci_utils/common/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def identify_matching_qcow_image(session,centos_arch, centos_version, image_base
run_cmd(session, "mkdir -p /var/lib/libguestfs/images/")

# Iterate from the last image backwards
for image_name in reversed(images_list):
for image_name in images_list:
image_name = image_name.strip()
if not image_name:
continue
Expand Down Expand Up @@ -204,7 +204,7 @@ def identify_matching_qcow_image(session,centos_arch, centos_version, image_base
logger.info(f"[INFO] Comparing kernel {kernel_ver_str} (normalized: {kernel_normalized}) with constraint {version_constraints} (normalized: {constraint_normalized})")

# Use LooseVersion for comparison
if LooseVersion(kernel_normalized) <= LooseVersion(constraint_normalized):
if LooseVersion(kernel_normalized) >= LooseVersion(constraint_normalized):
logger.info(f"[INFO] Kernel version meets constraint. Returning image URL: {image_url}")
return image_url
else:
Expand Down