projects(Teamtype): use demo module in tests without examples#1939
Open
Aman16102000 wants to merge 1 commit intongi-nix:mainfrom
Open
projects(Teamtype): use demo module in tests without examples#1939Aman16102000 wants to merge 1 commit intongi-nix:mainfrom
Aman16102000 wants to merge 1 commit intongi-nix:mainfrom
Conversation
eljamm
reviewed
Jan 8, 2026
Comment on lines
-37
to
-41
| tests.basic.module = import ./programs/teamtype/tests/basic.nix args; | ||
| tests.basic.problem.broken.reason = '' | ||
| Needs a self-hosted relay server to work non-interactively (without internet). | ||
| Requires: https://github.com/teamtype/teamtype/issues/344 | ||
| ''; |
Contributor
There was a problem hiding this comment.
Self-hosted relays still don't exist AFAIK, so the test shouldn't be unbroken. Please revert this.
| sources.modules.ngipkgs | ||
| sources.modules.programs.teamtype | ||
| sources.examples.Teamtype."Enable Teamtype" | ||
| sources.demos.Teamtype.shell |
Contributor
There was a problem hiding this comment.
A demo can be either shell or vm for any given project. It's a bit redundant to have to have to explicitly specify this. Instead, I think this makes more sense: sources.demos.Teamtype
Comment on lines
+82
to
+87
| demos = lib.mapAttrs ( | ||
| _: project: lib.filterAttrs (_: v: v != null) { | ||
| vm = project.nixos.demo.vm.module or null; | ||
| shell = project.nixos.demo.shell.module or null; | ||
| } | ||
| ) self.hydrated-projects; |
Contributor
There was a problem hiding this comment.
This is already composed in overview/demo/default.nix. We could just expose raw-demos and pass that to sources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1491